Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: enforce string nip metadata#478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tcheeric merged 1 commit intodevelopfromcodex/update-event-kind-type-to-string
Oct 12, 2025

Conversation

@tcheeric
Copy link
Owner

Summary

Related issue: #____

The NIP identifier associated with events and messages should follow the protocol definition that represents it as a string. The existing implementation still surfaced it as an integer, so callers could not rely on the string-based contract.

What changed?

  • Update the sharedIElement contract and message/event implementations to exposenip as aString.
  • Align the generic event builder helpers with the string-based signature.
  • Refresh the JSON parsing unit test to assert the new representation.

BREAKING

  • None.

Review focus

  • Confirm no remaining integer-basednip accessors are left in the event/message hierarchy.

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title isverb + object (e.g., “Refactor auth middleware to async”)
  • Description links the issue and answers “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (if relevant)

Testing

  • mvn -q verify
[ERROR] [ERROR] Some problems were encountered while processing the POMs:[ERROR] Non-resolvable import POM: The following artifacts could not be resolved: xyz.tcheeric:nostr-java-bom:pom:1.1.1 (absent): Could not find artifact xyz.tcheeric:nostr-java-bom:pom:1.1.1 in central (https://repo.maven.apache.org/maven2) @ line 100, column 25[ERROR] The build could not read 1 project -> [Help 1][ERROR][ERROR]   The project xyz.tcheeric:nostr-java:1.0.1-SNAPSHOT (/workspace/nostr-java/pom.xml) has 1 error[ERROR]     Non-resolvable import POM: The following artifacts could not be resolved: xyz.tcheeric:nostr-java-bom:pom:1.1.1 (absent): Could not find artifact xyz.tcheeric:nostr-java-bom:pom:1.1.1 in central (https://repo.maven.apache.org/maven2) @ line 100, column 25 -> [Help 2]

Limitations

  • Build currently blocked by the unresolvedxyz.tcheeric:nostr-java-bom:1.1.1 import.

Network Access

  • No blocked domains encountered; Maven Central responded but did not host the requested BOM artifact.

https://chatgpt.com/codex/tasks/task_b_68ec06d174548331a2b0365943ddea24

chatgpt-codex-connector[bot] reacted with thumbs up emoji
@tcheerictcheeric merged commit4df2582 intodevelopOct 12, 2025
1 check passed
@tcheerictcheeric deleted the codex/update-event-kind-type-to-string branchOctober 12, 2025 21:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tcheeric

[8]ページ先頭

©2009-2025 Movatter.jp