- Notifications
You must be signed in to change notification settings - Fork26
fix: enforce string nip metadata#478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4df2582 intodevelop 1 check passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #____
The NIP identifier associated with events and messages should follow the protocol definition that represents it as a string. The existing implementation still surfaced it as an integer, so callers could not rely on the string-based contract.
What changed?
IElementcontract and message/event implementations to exposenipas aString.BREAKING
Review focus
nipaccessors are left in the event/message hierarchy.Checklist
Testing
mvn -q verifyLimitations
xyz.tcheeric:nostr-java-bom:1.1.1import.Network Access
https://chatgpt.com/codex/tasks/task_b_68ec06d174548331a2b0365943ddea24