Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: replace sneaky throws with explicit handling#457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tcheeric merged 1 commit intodevelopfromcodex/create-tasks-for-milestone-1
Oct 6, 2025

Conversation

@tcheeric
Copy link
Owner

Summary

Related issue: #____

Responds to code review Finding 1.2 by removing Lombok's@SneakyThrows in favor of explicit exception handling across the event and API layers, so that JSON/URL failures surface as meaningful domain errors.

What changed?

  • Wrapped Jackson parsing in marketplace, merchant, and identity-related events withEventEncodingException so invalid content fails fast without hidden checked exceptions.
  • Updated API builders (NIP-05/25/57/60/61) andBaseTagFactory to convert checked exceptions into descriptiveIllegalArgumentException/EventEncodingException instances instead of relying on@SneakyThrows.
  • Revised affected integration/unit tests to document intent, remove@SneakyThrows, and assert JSON parsing success explicitly.

BREAKING

None.

Review focus

  • Confirm the new exception messages and types provide adequate signal for callers consuming the updated APIs.

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title isverb + object (e.g., “Refactor auth middleware to async”)
  • Description links the issue and answers “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (if relevant)

Testing

  • mvn -q verify(fails: xyz.tcheeric:nostr-java-bom:1.1.1 missing from Maven Central)

Network Access

  • Attempted to downloadhttps://repo.maven.apache.org/maven2/xyz/tcheeric/nostr-java-bom/1.1.1/nostr-java-bom-1.1.1.pom (artifact not found).

https://chatgpt.com/codex/tasks/task_b_68e337e2acfc83319e62250f0db94bc8

chatgpt-codex-connector[bot] reacted with thumbs up emoji
@codecov-commenter
Copy link

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit ourtroubleshooting guide.

@tcheerictcheeric merged commit1a86ffb intodevelopOct 6, 2025
2 checks passed
@tcheerictcheeric deleted the codex/create-tasks-for-milestone-1 branchOctober 6, 2025 04:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tcheeric@codecov-commenter

[8]ページ先頭

©2009-2025 Movatter.jp