- Notifications
You must be signed in to change notification settings - Fork26
fix: replace sneaky throws with explicit handling#457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecov-commenter commentedOct 6, 2025
|
1a86ffb intodevelop 2 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #____
Responds to code review Finding 1.2 by removing Lombok's
@SneakyThrowsin favor of explicit exception handling across the event and API layers, so that JSON/URL failures surface as meaningful domain errors.What changed?
EventEncodingExceptionso invalid content fails fast without hidden checked exceptions.BaseTagFactoryto convert checked exceptions into descriptiveIllegalArgumentException/EventEncodingExceptioninstances instead of relying on@SneakyThrows.@SneakyThrows, and assert JSON parsing success explicitly.BREAKING
None.
Review focus
Checklist
Testing
mvn -q verify(fails: xyz.tcheeric:nostr-java-bom:1.1.1 missing from Maven Central)Network Access
https://repo.maven.apache.org/maven2/xyz/tcheeric/nostr-java-bom/1.1.1/nostr-java-bom-1.1.1.pom(artifact not found).https://chatgpt.com/codex/tasks/task_b_68e337e2acfc83319e62250f0db94bc8