- Notifications
You must be signed in to change notification settings - Fork26
refactor: revamp docs, align BOM JUnit, add typed tag helpers, and bump to 0.6.0#453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Complete changelog documenting 187 commits across 9 months:- Major features: Streaming subscriptions, BOM migration, docs overhaul- Technical improvements: Refactoring, NIP-05 enhancement, CI/CD- 387 files changed, +18,150/-13,754 lines- Maintained 100% backward API compatibility🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>
…mented code, generics)
…dundant casts, imports)
…tags, messages, and event impls
…lify relays Map injection in IT; refactor: use typed tag helpers fallback in NIP04/NIP44/NIP57
codecov-commenter commentedOct 6, 2025
|
6146268 intodevelopUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| GenericEventzappedEvent, | ||
| BaseTagaddressTag) { | ||
| if (!relaysTags.getCode().equals(Constants.Tag.RELAYS_CODE)) { | ||
| if (!(relaysTagsinstanceofRelaysTag)) { | ||
| thrownewIllegalArgumentException("tag must be of type RelaysTag"); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Rejecting non-RelaysTag inputs in createZapRequestEvent
The new guardif (!(relaysTags instanceof RelaysTag)) now throws whenever callers pass a genericBaseTag whose code is"relays". Before this change the method only checked the tag code, so callers could (and inNIP57ImplTest still do) passBaseTag.create("relays", url) without constructing a dedicatedRelaysTag. Because the method signature still acceptsBaseTag, this silently turns previously valid usage into anIllegalArgumentException at runtime and drops support for generic relays tags. If the intent is to requireRelaysTag, the parameter type should be narrowed and the break documented; otherwise the old code check should be preserved to avoid breaking existing clients.
Useful? React with 👍 / 👎.
Summary
This PR revamps documentation, aligns test dependencies via the project BOM, introduces typed tag lookup helpers to reduce casts and improve safety, fixes a Spring test bean ambiguity, and
bumps the project version to 0.6.0.
Related issue: #____
What changed?
BREAKING
Review focus
Checklist
Testing
developer/CI environments or with the Mockito Java agent set per docs.
Network Access
Notes
restrictions.
depending on the newer helper signature for those API files, but the code is otherwise equivalent in type safety and behavior.