Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: surface build errors in workflow#398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@tcheeric
Copy link
Owner

Summary

  • capture Maven build output to a log file
  • print build errors before the log tail on failure

Testing

  • ./mvnw -q verify(fails: Network is unreachable)

https://chatgpt.com/codex/tasks/task_b_68a6ed11578c8331a3cf9a256362f5b6

@codecov-commenter
Copy link

⚠️ Please install the'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report?Let us know!

@tcheerictcheeric requested a review fromCopilotAugust 21, 2025 10:11
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR enhances the CI workflow to capture and display Maven build output for better debugging when builds fail. The change improves the visibility of build errors by capturing output to a log file and displaying relevant error information on failure.

  • Captures Maven build output to a log file usingtee
  • Adds a conditional step to display build errors and log tail when builds fail

cache:'maven'
-name:Build with Maven
run:./mvnw -q verify
run:./mvnw -q verify |& tee build.log

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The|& operator is a bash-specific feature that may not be available in all shell environments. Consider using2>&1 | tee build.log for better portability across different shells.

Suggested change
run:./mvnw -q verify|& tee build.log
run:./mvnw -q verify2>&1 | tee build.log

Copilot uses AI. Check for mistakes.
if:failure()
run:|
echo "Build error"
grep '^\[ERROR\]' build.log ||true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[nitpick] The regex pattern^\[ERROR\] assumes Maven's specific error message format. Consider making this more robust by also checking for other common error patterns or using Maven's built-in error reporting flags.

Suggested change
grep '^\[ERROR\]' build.log || true
egrep '^\[ERROR\]|BUILD FAILURE|Exception|Caused by:' build.log || true

Copilot uses AI. Check for mistakes.
@tcheerictcheeric merged commit6669f36 intodevelopAug 21, 2025
2 of 3 checks passed
@tcheerictcheeric deleted the codex/update-ci-workflow-to-log-build-errors branchAugust 21, 2025 10:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tcheeric@codecov-commenter

[8]ページ先頭

©2009-2025 Movatter.jp