- Notifications
You must be signed in to change notification settings - Fork26
Add tests and adjust JaCoCo configuration#265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add tests and adjust JaCoCo configuration#265
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds unit tests to the base and encryption modules while configuring JaCoCo code coverage to skip modules that don't have tests. The changes focus on improving test coverage for core functionality while pragmatically excluding modules from coverage analysis.
Key changes:
- Added comprehensive unit tests for encryption (MessageCipher04/44) and base module classes (Relay, Marker, Kind, Command, BaseKey)
- Updated POM files to skip JaCoCo coverage for modules without tests (id, examples, event, encryption, client, api)
- Expanded existing BaseKeyTest with additional method coverage
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nostr-java-encryption/src/test/java/nostr/encryption/MessageCipherTest.java | New test file covering encryption/decryption for both MessageCipher04 and MessageCipher44 |
| nostr-java-base/src/test/java/nostr/base/*.java | New test files for Relay, Marker, Kind, and Command classes |
| nostr-java-base/src/test/java/nostr/base/BaseKeyTest.java | Enhanced existing tests with additional method coverage |
| */pom.xml | Added jacoco.skip=true property to exclude modules from coverage analysis |
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
563111f intodevelopUh oh!
There was an error while loading.Please reload this page.
Summary
Testing
mvn -q verify(fails: Could not find a valid Docker environment, Testcontainers integration tests)https://chatgpt.com/codex/tasks/task_b_6896c4960e5c8331ba7cb5cd391eac29