- Notifications
You must be signed in to change notification settings - Fork26
Enable relay-dependent integration tests#226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR enables relay-dependent integration tests to run conditionally based on relay availability. Previously, integration tests were statically disabled and required manual intervention to run.
- Replaces static
@Disabledannotations with dynamic relay availability checking - Introduces helper classes for checking relay connectivity before test execution
- Updates documentation to reflect automatic test skipping behavior
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
RelayAvailability.java | New utility class to check if configured relays are reachable via socket connections |
BaseRelayIntegrationTest.java | New base class that skips tests when relays are unavailable using JUnit assumptions |
Multiple*IT.java files | Remove static@Disabled annotations and extend new base class for conditional execution |
README.md | Documents automatic skipping of integration tests when relays are unreachable |
nostr-java-api/src/test/java/nostr/api/integration/RelayAvailability.java OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
nostr-java-api/src/test/java/nostr/api/integration/RelayAvailability.java OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
nostr-java-api/src/test/java/nostr/api/integration/RelayAvailability.java OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…bility.javaCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…bility.javaCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…bility.javaCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Summary
RelayAvailabilityhelper andBaseRelayIntegrationTestbase class@Disabledannotations from integration testsTesting
mvn verifyhttps://chatgpt.com/codex/tasks/task_b_688a83c6ff908331ae096bb4ff153224