Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

various minor updates & cleanup#206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
avlo merged 41 commits intotcheeric:developfromavlo:upstream-develop-snapshot
May 16, 2025

Conversation

@avlo
Copy link
Collaborator

hi, eric. below PR consisting of minor changes/cleanup, with special note on first item:

  • GenericTag relocated from nostr.event.impl to nostr.event.tag

for any library users explicitly using GenericTag it is technically a breaking change although i suspect all/most users use concrete tag implementations (EventTag, PubKeyTag, etc) directly, which are all unchanged.

general:

  • AddressableTagFilter renamed to AddressTagFilter
  • TagSerializer split into BaseTagSerializer and GenericTagSerializer implementations
  • BaseTagSerializer and GenericTagSerializer extend newly introduced AbstractTagSerializer
  • BaseTagEncoder updated to use BaseTagSerializer
  • BaseTag.getFieldValue() potential null String result replaced with Optional
  • added VoteTag & VoteTagFilter
  • GenericMessage.decode() method updated to use Stream
  • BaseMessageDecoder cleaned up
  • added VoteTagFilter to FilterableProvider
  • cleaned up SignatureDeserializer
  • OkMessage.decode() cleaned up

tests:

  • refactored common/useful test patterns into CommonTestObjectsFactory class
  • new and updated tests added for all the above, all passing
  • various gradle build/config updates

all/any concerns, questions, additional considerations, etc, welcome as always

avlo added30 commitsMarch 21, 2025 02:54
…ing exceptionAbstractTagSerializer now uses above Optional in serialization streamAbstractTagSerializer removed failableStream since no longer needed to handle above stream exceptionstest updates accordingly
@avloavlo requested a review fromtcheericApril 29, 2025 04:13
@avloavlo added the awaiting reviewPR awaiting review labelApr 29, 2025
@tcheeric
Copy link
Owner

Thanks nick. I also have some changes in the pipeline. I'll work on it this weekend or earlier.

avlo reacted with thumbs up emoji

@avlo
Copy link
CollaboratorAuthor

avlo commentedApr 30, 2025
edited
Loading

yw, sounds good & thx you as well. btw, if easier/convenient for you, we can hold off on this PR until your changes are merged into develop branch, after which i'll update this PR with those changes and then merge this PR into develop branch.

@tcheerictcheeric reopened thisMay 4, 2025
@tcheerictcheeric added review:approvedPR review approved and removed awaiting reviewPR awaiting review labelsMay 16, 2025
@avloavlo merged commitbe56d10 intotcheeric:developMay 16, 2025
@avlo
Copy link
CollaboratorAuthor

avlo commentedMay 16, 2025
edited
Loading

excellent, thx eric- btw, minor supplemental update was just pushed into develop branch as well.

@avloavlo deleted the upstream-develop-snapshot branchMay 16, 2025 17:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tcheerictcheerictcheeric approved these changes

Assignees

No one assigned

Labels

review:approvedPR review approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avlo@tcheeric

[8]ページ先頭

©2009-2025 Movatter.jp