- Notifications
You must be signed in to change notification settings - Fork26
various minor updates & cleanup#206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ests returning them
…ing exceptionAbstractTagSerializer now uses above Optional in serialization streamAbstractTagSerializer removed failableStream since no longer needed to handle above stream exceptionstest updates accordingly
tcheeric commentedApr 30, 2025
Thanks nick. I also have some changes in the pipeline. I'll work on it this weekend or earlier. |
avlo commentedApr 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
yw, sounds good & thx you as well. btw, if easier/convenient for you, we can hold off on this PR until your changes are merged into develop branch, after which i'll update this PR with those changes and then merge this PR into develop branch. |
avlo commentedMay 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
excellent, thx eric- btw, minor supplemental update was just pushed into develop branch as well. |
hi, eric. below PR consisting of minor changes/cleanup, with special note on first item:
for any library users explicitly using GenericTag it is technically a breaking change although i suspect all/most users use concrete tag implementations (EventTag, PubKeyTag, etc) directly, which are all unchanged.
general:
tests:
all/any concerns, questions, additional considerations, etc, welcome as always