Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

markdown checker#226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
oyilmaztekin wants to merge36 commits intotc39:main
base:main
Choose a base branch
Loading
fromoyilmaztekin:ozer-check-markdown

Conversation

@oyilmaztekin
Copy link
Contributor

#140

  • added markdown reader
  • parsed markdown to the AST
  • detected all tables
  • collected all link definitions
  • started to add tests

Discussions:#140 (comment)

ExE-Boss, okmttdhr, yashraj-02, ctcpip, and asaneh reacted with thumbs up emoji
added parserdetected all tables into the MD filecollected all link definitionsstarted to add tests
changed pacakge publication to private
@oguzzkilic
Copy link

Adding it in eslint + airbnb configuration can be good for code standard.

simonwep, ljharb, and bismarkhenao reacted with thumbs up emoji

oyilmaztekinand others added10 commitsJuly 3, 2019 00:30
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
added missing newlines
@septs
Copy link
Member

septs commentedSep 27, 2020
edited
Loading

@ljharb

  1. I want to integratehttps://github.com/DavidAnson/markdownlint in gh-actions on push and pull-request pre-check

  2. I want to integrate a link checker that is available every day

    1. check is redirected (3xx status code)
      e.q: repo transferred or renamed

    2. check is not found (404 status code)
      e.q: repo deleted

    3. don't check not github

  3. AddVisual Studio Code pre-settings

    1. .vscode/settings.json
    {    "editor.formatOnSave": true, // auto format    "editor.codeActionsOnSave": {    "source.fixAll": true // auto fix }}
    1. .vscode/extensions.json

    prompt to install extensions

    {  "recommendations": ["DavidAnson.vscode-markdownlint"]}
ctcpip reacted with thumbs up emoji

@Jack-Works
Copy link
Member

Not everyone using VSCode.

@ljharb
Copy link
Member

Definitely editor-specific stuff isn't a good idea to include. If it's a linter tho, it should be able to run locally via eslint, which would be fine.

The trick with an action (or any CI check) is that inevitably someone's going to be blocked by a link going dark when it's unrelated to the change they're making. What we really need is something that can notice a link is dead, and then open up a PR or issue about it.

@septs
Copy link
Member

@ljharb i think, i can integrate one link-checker on github action

on push and scheduled (run once a day)

@ljharb
Copy link
Member

@septs how would we be notified when it failed? would that cause PRs to suddenly be blocked?

@septs
Copy link
Member

@ljharb ye, will a notification, but will not prevent PR.

ljharb reacted with thumbs up emoji

@septs
Copy link
Member

septs commentedSep 28, 2020
edited
Loading

@septs
Copy link
Member

@oyilmaztekin
Copy link
ContributorAuthor

oyilmaztekin commentedSep 11, 2021
edited
Loading

@ljharb@littledan@chicoxyzzy final JSON output was created for stage 1. Still, things need to be improved, but let's discuss the outputjson file thathas been added to the commit. This output was created automatically. Also, you can share your concerns about deployment pipeline implementation and the code quality.

For refreshing memories of what this PR was about
#140 (comment)
#188

@oyilmaztekin
Copy link
ContributorAuthor

In addition, you can review the JSON outputhere. It will be the final result after we are done with that PR

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ljharbljharbljharb requested changes

+2 more reviewers

@chicoxyzzychicoxyzzychicoxyzzy left review comments

@MaxKingsleeMaxKingsleeMaxKingslee approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@oyilmaztekin@oguzzkilic@septs@Jack-Works@ljharb@chicoxyzzy@MaxKingslee

[8]ページ先頭

©2009-2025 Movatter.jp