- Notifications
You must be signed in to change notification settings - Fork737
markdown checker#226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
markdown checker#226
Uh oh!
There was an error while loading.Please reload this page.
Conversation
added parserdetected all tables into the MD filecollected all link definitionsstarted to add tests
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
removed husky
Uh oh!
There was an error while loading.Please reload this page.
changed pacakge publication to private
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
oguzzkilic commentedJul 2, 2019
Adding it in eslint + airbnb configuration can be good for code standard. |
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
added missing newlines
…/proposals into ozer-check-markdown
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
eslint integration
refactored index.jssplitted some utils functions
septs commentedSep 27, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
Jack-Works commentedSep 27, 2020
Not everyone using VSCode. |
ljharb commentedSep 28, 2020
Definitely editor-specific stuff isn't a good idea to include. If it's a linter tho, it should be able to run locally via eslint, which would be fine. The trick with an action (or any CI check) is that inevitably someone's going to be blocked by a link going dark when it's unrelated to the change they're making. What we really need is something that can notice a link is dead, and then open up a PR or issue about it. |
septs commentedSep 28, 2020
@ljharb i think, i can integrate one link-checker on github action on push and scheduled (run once a day) |
ljharb commentedSep 28, 2020
@septs how would we be notified when it failed? would that cause PRs to suddenly be blocked? |
septs commentedSep 28, 2020
@ljharb ye, will a notification, but will not prevent PR. |
septs commentedSep 28, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
septs commentedSep 28, 2020
adds some refactoring
removes .idea folder
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
removes html from table heads
oyilmaztekin commentedSep 11, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@ljharb@littledan@chicoxyzzy final JSON output was created for stage 1. Still, things need to be improved, but let's discuss the output For refreshing memories of what this PR was about |
oyilmaztekin commentedSep 13, 2021
In addition, you can review the JSON outputhere. It will be the final result after we are done with that PR |
#140
Discussions:#140 (comment)