can you check if all the relevant tests for templates pass with this change?

The resulting scenarios look good in the UI. I have some minor concern about the implementation.
I have an issue with removing the exception. The Template module is responsible for the all things related to message templates. Thetemplate_name_label is supposed to return valid template names. So if the number of approved fact checks is more than 2, raising an exception is the expected behavior. If we return a string from that function, its not right.

There must be a way to capture that exception and do appropriate things in the UI.

Hey@dennyabrain, I have run all the tests in the/test/dau/user_message/templates directory, and every test case was successful.

Regarding your concern about the exception, thetemplate_name_label function is getting called insideassign_template_name in theFactory.process function (ref:https://github.com/tattle-made/dau-dashboard/blob/main/lib/dau/user_message/templates/factory.ex), where the common stuct is passed through a pipeline of different functions to return the template query with all the relevant data and metadata.

The issue is how thisFactory.process function gets called throughout the project. Inside thedetail.html.heex file, we are calling theFactory.process through different functions directly.Reference to the relevant line in the code.

In the above reference, in lines 375 and 377, we are calling functions that callFactory.process() and return different things. One returns a Boolean value for whether the template is valid or not. Other returns the template string that gets previewed in the "User Response" section.

As we approve any article, the@query state changes, triggering these functions. As these functions are not handle event callback functions, they don't have access to the socket. We can still use try and rescue to catch the error raised, but we cannot put any flash or update any state, indicating that some error has occurred. (We can update the User Message preview though, because it is returned by one of these functions and the output is directly rendered).

Also, in thetemplate_name_label function, it has to return a string for the normal execution of theFactory.process, as later, this string gets evaluated for checking the names. Currently (in this PR after removing "raise"), by default, it returns "Too many fact check articles", so if there are more than 2 articles approved, it would generate a template likedeepfake_wo_ar_Too many fact check articles_en, which is never going to match any case.

So, I understand that approving more articles is an unusual event, but in this case, it is checking "Too many articles" as a case and handling it automatically and then indicating that "there is no match for this case" as well in a standard way like it doing for all other unmatched cases.

One other way that we can approach this is to not allow adding more than the required articles in the beginning itself. But then we would also need to provide a way to delete the added articles as well (which I was thinking of adding as a feature in a separate issue on its own in any case).

Let me know your thoughts!