NotificationsYou must be signed in to change notification settings
Fork5k
Star24.5k

fix(tmq): tmq_get_json_meta return null if alter stable in schemaless#33754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

wangmm0220 wants to merge7 commits intomain

base:main

Choose a base branch

fromfix/tmq_get_json

Open

fix(tmq): tmq_get_json_meta return null if alter stable in schemaless#33754

wangmm0220 wants to merge7 commits intomainfromfix/tmq_get_json

+259 −140

Conversation

Copy link

Contributor

wangmm0220 commentedNov 28, 2025

Description

Please briefly describe the code changes in this pull request.

Jira:https://jira.taosdata.com:18080/browse/TD-

Checklist

Please check the items in the checklist if applicable.

Is the user manual updated?
Are the test cases passed and automated?
Is there no significant decrease in test coverage?

fix(tmq): tmq_get_json_meta return null if alter stable in schemaless

2746984

wangmm0220 requested review fromdapan1121,guanshengliang andhzcheng ascode owners

November 28, 2025 07:05

Copy link

Contributor

gemini-code-assistbot commentedNov 28, 2025

Summary of Changes

Hello@wangmm0220, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue wheretmq_get_json_meta would return null when a supertable was altered in a schemaless environment. The core change involves introducing a new function to correctly build and serialize alter messages for supertables, ensuring that the necessary metadata is properly generated and passed during alteration operations. Additionally, a minor type refactoring was performed to enhance code consistency.

Highlights

NewbuildAlterMsg Function: A new static utility functionbuildAlterMsg has been introduced inmndStb.c. This function is responsible for dynamically constructing and serializingSMAlterStbReq messages, specifically designed to supporttmq_get_json_meta when supertable alterations occur.
Integration of Alter Message Generation: ThemndProcessCreateStbReq function now utilizes the newly addedbuildAlterMsg to generate and pass the correct alter message buffer and length tomndAlterStbImp. This ensures thattmq_get_json_meta receives accurate metadata when a supertable is altered in a schemaless context, resolving the issue of it returning null.
Type Consistency Refactoring: InparTranslater.c, all instances ofTAOS_FIELD have been replaced withSField within thebuildAlterSuperTableReq function. This change standardizes the data type used for field definitions, improving consistency across the codebase.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

taosdata-botbot added the team engine label

Nov 28, 2025

gemini-code-assistbot reviewed

Nov 28, 2025

View reviewed changes

Copy link

Contributor

gemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request introduces a new functionbuildAlterMsg to construct a message forALTER TABLE operations, which is then used inmndProcessCreateStbReq. While the goal is to fix an issue withtmq_get_json_meta, the implementation ofbuildAlterMsg contains several critical issues, including an out-of-bounds memory access and a copy-paste error that could lead to a crash. Additionally, the logic currently only handles the first schema change it detects, which could lead to incomplete alter operations if multiple schema changes are present. The changes inparTranslater.c for type consistency are good. I've provided suggestions to fix the critical bugs and improve the logic.

source/dnode/mnode/impl/src/mndStb.cShow resolvedHide resolved

source/dnode/mnode/impl/src/mndStb.c OutdatedShow resolvedHide resolved

wangmm0220 added2 commits

November 28, 2025 16:03

fix(tmq): tmq_get_json_meta return null if alter stable in schemaless

216661f

fix(tmq): tmq_get_json_meta return null if alter stable in schemaless

03998b4

Copy link

ContributorAuthor

wangmm0220 commentedNov 28, 2025

/gemini review

fix(tmq): tmq_get_json_meta return null if alter stable in schemaless

32dfc77

gemini-code-assistbot reviewed

Nov 28, 2025

View reviewed changes

Copy link

Contributor

gemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request aims to fix an issue wheretmq_get_json_meta would not returnnull for analter stable operation in schemaless mode. The changes involve adding a null check for JSON items before adding them to an array, which is correct. However, there are a few issues introduced:

InclientRawBlockWrite.c, new checks are added, but they only log errors without proper error handling, which could lead to crashes or undefined behavior. I've suggested fixes for these.
InmndStb.c, a new helper functionbuildAlterMsg is introduced, but it contains a compilation error due to an undeclared variable. I've provided a comment to fix this critical issue.

Overall, the direction of the fix is correct, but the implementation needs these corrections to be robust and error-free.