NotificationsYou must be signed in to change notification settings
Fork5k
Star24.5k

fix: order by abs(col) column not found if col not in table#33722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Tony2h wants to merge3 commits into3.3.6

base:3.3.6

Choose a base branch

fromfix/3.3.6/TD-38284

Open

fix: order by abs(col) column not found if col not in table#33722

Tony2h wants to merge3 commits into3.3.6fromfix/3.3.6/TD-38284

+85 −5

Conversation

Copy link

Contributor

Tony2h commentedNov 26, 2025

Description

Please briefly describe the code changes in this pull request.

Jira:https://jira.taosdata.com:18080/browse/TD-

Checklist

Please check the items in the checklist if applicable.

Is the user manual updated?
Are the test cases passed and automated?
Is there no significant decrease in test coverage?

Tony Zhang added2 commits

November 26, 2025 14:51

fix: order by abs(col) column not found if col not in table

1e76230

add ci test

d16f499

Tony2h requested review froma team,dapan1121,guanshengliang andhzcheng ascode owners

November 26, 2025 08:28

Copy link

Contributor

gemini-code-assistbot commentedNov 26, 2025

Summary of Changes

Hello@Tony2h, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a parsing bug in SQLORDER BY clauses that prevented queries from correctly executing when an aggregate function, such asABS(), was applied to a column alias defined within theSELECT list. The changes refine the column resolution logic to ensure that aliases are properly recognized and prioritized inORDER BY expressions, thereby enhancing the robustness and flexibility of SQL query processing. A comprehensive test case has been added to cover various scenarios involvingORDER BY with aliases.

Highlights

Bug Fix: ORDER BY with ABS(alias): Resolved an issue whereORDER BY abs(col) would fail ifcol was an alias in theSELECT list and not a direct column in the table. The parser now correctly resolves such aliases.
Parser Logic Refinement: ThetranslateColumn function inparTranslater.c has been updated to improve the resolution of column names inORDER BY clauses, ensuring aliases from theSELECT list are correctly identified, even when used within functions.
New Test Case Added: A new Python test file,test_order_by_select_list.py, has been introduced to validate the correct behavior ofORDER BY clauses when using column aliases, including scenarios with functions likeABS() and cases where aliases might conflict with table column names.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

taosdata-botbot added the team engine label

Nov 26, 2025

empty

8be9721

gemini-code-assistbot reviewed

Nov 26, 2025

View reviewed changes

Copy link

Contributor

gemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request correctly fixes an issue where an aliased column within a function in anORDER BY clause was not being resolved. The change inparTranslater.c is minimal and effective. The new test file,test_order_by_select_list.py, provides good coverage for the fix and related scenarios. Overall, the changes are solid. I have one minor style suggestion for the new test file.

test/cases/07-DataQuerying/04-OrderBy/test_order_by_select_list.py

		tdSql.checkData(2,0,'2025-01-01 11:00:00')
		tdSql.checkData(2,1,1)

		tdLog.info(f"=============== End test Order By Select List") No newline at end of file

This comment was marked as off-topic.

dapan1121 reviewed

Nov 27, 2025

View reviewed changes

source/libs/parser/src/parTranslater.c

		}
		}
		if (clauseSupportAlias(pCxt->currClause) &&!(*pCol)->node.asParam &&res != DEAL_RES_CONTINUE &&
		if (clauseSupportAlias(pCxt->currClause) && res != DEAL_RES_CONTINUE &&