Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork229
wip: Improve value parsing#1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
thecrypticace wants to merge2 commits intomainChoose a base branch fromfeat/improve-value-parsing
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5c1a316
tocfa251d
Compare4877d8d
to87ef383
Comparethecrypticace added a commit that referenced this pull requestOct 6, 2025
Fixes#1463We'll have to bail in some cases that we didn't before to fix this. Thisseems fine though. The core problem was that given this theme:```css@theme { --radius: calc(var(--radius));}```We'd see this CSS:```css.rounded { border-radius: calc(var(--radius));}```And we'd try to replace variables in `calc(var(--radius))`. This doesn't_start_ with a var(…) so our recursion guards didn't catch this.This entire system is a bit fragile and I'll be working to clean this upalong with how we handle pixel equivalents, light-dark replacements,color-mix replacements, etc… in some future PRs (#1330 is one of thosebut I want to reorganize + tweak some code first in an earlier PR whichwill make that one "nicer")
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This builds on top of#1316 to simplify and improve value parsing in the language service. It's fairly easy to trip up the regexes we use to match and replace things. This PR changes things around to use proper parsers that implement the same algorithms that CSS uses.
There's still a lot of work left to make use of these new parsers everywhere that is necessary.
Fixes#1210