Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

wip: Improve value parsing#1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
thecrypticace wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromfeat/improve-value-parsing

Conversation

thecrypticace
Copy link
Contributor

@thecrypticacethecrypticace commentedApr 22, 2025
edited
Loading

This builds on top of#1316 to simplify and improve value parsing in the language service. It's fairly easy to trip up the regexes we use to match and replace things. This PR changes things around to use proper parsers that implement the same algorithms that CSS uses.

There's still a lot of work left to make use of these new parsers everywhere that is necessary.

Fixes#1210

@thecrypticacethecrypticaceforce-pushed thefix/better-calc-evaluation branch 2 times, most recently from5c1a316 tocfa251dCompareApril 23, 2025 15:02
Base automatically changed fromfix/better-calc-evaluation tomainApril 23, 2025 15:12
wipwipwipwipwipwipwipwipwip
@thecrypticacethecrypticace added this to the0.16.0 milestoneSep 30, 2025
thecrypticace added a commit that referenced this pull requestOct 6, 2025
Fixes#1463We'll have to bail in some cases that we didn't before to fix this. Thisseems fine though. The core problem was that given this theme:```css@theme {  --radius: calc(var(--radius));}```We'd see this CSS:```css.rounded {  border-radius: calc(var(--radius));}```And we'd try to replace variables in `calc(var(--radius))`. This doesn't_start_ with a var(…) so our recursion guards didn't catch this.This entire system is a bit fragile and I'll be working to clean this upalong with how we handle pixel equivalents, light-dark replacements,color-mix replacements, etc… in some future PRs (#1330 is one of thosebut I want to reorganize + tweak some code first in an earlier PR whichwill make that one "nicer")
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

Color swatch not showing up for variables using theme
1 participant
@thecrypticace

[8]ページ先頭

©2009-2025 Movatter.jp