- Notifications
You must be signed in to change notification settings - Fork2k
net/wsconn: remove homegrown wrapper for turning a websocket.Conn into a net.Conn#4806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…o a net.ConnThe one from the nhooyr/websocket package seems to work equally well.Signed-off-by: Mihai Parparita <mihai@tailscale.com>
bradfitz approved these changesJun 7, 2022
mihaip added a commit that referenced this pull requestOct 18, 2022
… a net.ConnWe removed it in#4806 in favor of the built-in functionality from thenhooyr.io/websocket package. However, it has an issue with deadlinesthat has not been fixed yet (seecoder/websocket#350). Temporarilygo back to using a custom wrapper (using the fix from our fork) so thatderpers will stop closing connections too aggressively.Updates#5921Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip added a commit that referenced this pull requestOct 18, 2022
… a net.ConnWe removed it in#4806 in favor of the built-in functionality from thenhooyr.io/websocket package. However, it has an issue with deadlinesthat has not been fixed yet (seecoder/websocket#350). Temporarilygo back to using a custom wrapper (using the fix from our fork) so thatderpers will stop closing connections too aggressively.Updates#5921Signed-off-by: Mihai Parparita <mihai@tailscale.com>
mihaip added a commit that referenced this pull requestOct 18, 2022
… a net.ConnWe removed it in#4806 in favor of the built-in functionality from thenhooyr.io/websocket package. However, it has an issue with deadlinesthat has not been fixed yet (seecoder/websocket#350). Temporarilygo back to using a custom wrapper (using the fix from our fork) so thatderpers will stop closing connections too aggressively.Updates#5921Signed-off-by: Mihai Parparita <mihai@tailscale.com>
bradfitz pushed a commit that referenced this pull requestOct 21, 2022
… a net.ConnWe removed it in#4806 in favor of the built-in functionality from thenhooyr.io/websocket package. However, it has an issue with deadlinesthat has not been fixed yet (seecoder/websocket#350). Temporarilygo back to using a custom wrapper (using the fix from our fork) so thatderpers will stop closing connections too aggressively.Updates#5921Change-Id: I1597644e8ba47b413e33f2201eab935145566c0eSigned-off-by: Mihai Parparita <mihai@tailscale.com>(cherry picked from commit9d04ffc)
bradfitz pushed a commit that referenced this pull requestOct 21, 2022
… a net.ConnWe removed it in#4806 in favor of the built-in functionality from thenhooyr.io/websocket package. However, it has an issue with deadlinesthat has not been fixed yet (seecoder/websocket#350). Temporarilygo back to using a custom wrapper (using the fix from our fork) so thatderpers will stop closing connections too aggressively.Updates#5921Change-Id: I1597644e8ba47b413e33f2201eab935145566c0eSigned-off-by: Mihai Parparita <mihai@tailscale.com>(cherry picked from commit9d04ffc)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one from the nhooyr/websocket package seems to work equally well.
Signed-off-by: Mihai Parparitamihai@tailscale.com