Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork125
Git is not requirement for thenew command#655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| iferr:=initProjectGit(c,dir);err!=nil { | ||
| returnerr | ||
| } | ||
| iferr:=initProjectGit(c,dir);err!=nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
At this point, the check has already been done, so we know Git is available.
f56bb78 intomainUh oh!
There was an error while loading.Please reload this page.
| returnerr | ||
| } | ||
| if!c.Bool("no-git") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@fabpot this early return prevents adding the cloud files to git and breaks the cloud initialization. I think it should be changed to achieve the intended behavior:
if c.Bool("no-git") { return nil}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No description provided.