Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork125
Add support forpie#587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tucksaun commentedMar 24, 2025
Seems like we should be able by reimplementing the logic behind |
tucksaun left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for this solid addition!
Having not play with PIE yet, I would just like give it a go locally before a definitive approval 🙂
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
alexandre-daubois commentedMar 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I addressed your comments. I'll have a look at what's possible about |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
4cfd3bc to5820f61Comparetucksaun commentedMar 30, 2025
PIE is quite cutting-edge as of now so I think we can merge as-is and address this in the coming days/weeks. |
b3e8467 intosymfony-cli:mainUh oh!
There was an error while loading.Please reload this page.
tucksaun commentedMar 30, 2025
Thank you@alexandre-daubois ! |
OskarStark commentedMar 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Can we have any docs 🙃? |
alexandre-daubois commentedMar 31, 2025
I'm not sure where we should add this. I would have go forhttps://symfony.com/doc/current/setup/symfony_server.html, but "Symfony Local Web Server" doesn't seem suitable. However it seems the only place we could add this type of doc? Maybe a whole section to wrappers should be added also. |
tucksaun commentedMar 31, 2025
I started to talk about this with a couple of people and I believe we should introduce a dedicated documentation for the CLI with the more advanced options and only have an introduction in the Framework doc (with a link to the dedicated one). This could also help with the fact that currently the documentation for the CLI does not take the CLI version into account because it is being embedded in the Framework documentation. WDYT? |
alexandre-daubois commentedMar 31, 2025
100% agree, I'm pretty sure many (most?) people underuse Symfony CLI because there's no clear dedicated page to it. Let's create an issue in symfony-docs 🙂 |
Just like
composerandpecl, I think thesymfonytool could propose thepiesubcommand.For now I don't think we can get the phar signature of the latest release. Could this be possible to maybe include the signature as a release artifact maybe@asgrim, or similar mechanism? 🙂 Composer offers to download the latest signature athttps://composer.github.io/installer.sig. Please tell me if I can be of any help on this!
This could also be an opportunity to resume#435 by adding a few integration tests for this command?