Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add support forpie#587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tucksaun merged 1 commit intosymfony-cli:mainfromalexandre-daubois:pie-bin
Mar 30, 2025
Merged

Conversation

@alexandre-daubois
Copy link
Contributor

Just likecomposer andpecl, I think thesymfony tool could propose thepie subcommand.

For now I don't think we can get the phar signature of the latest release. Could this be possible to maybe include the signature as a release artifact maybe@asgrim, or similar mechanism? 🙂 Composer offers to download the latest signature athttps://composer.github.io/installer.sig. Please tell me if I can be of any help on this!

This could also be an opportunity to resume#435 by adding a few integration tests for this command?

@tucksaun
Copy link
Member

For now I don't think we can get the phar signature of the latest release. Could this be possible to maybe include the signature as a release artifact maybe@asgrim, or similar mechanism? 🙂

Seems like we should be able by reimplementing the logic behindgh attestation verify. (for reference here is a link to start the investigation:https://github.com/cli/cli/blob/trunk/pkg/cmd/attestation/verify/verify.go). though having a signature as Composer would be definitely easier to implement and maintain.

alexandre-daubois reacted with eyes emoji

Copy link
Member

@tucksauntucksaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this solid addition!

Having not play with PIE yet, I would just like give it a go locally before a definitive approval 🙂

alexandre-daubois reacted with rocket emoji
@alexandre-daubois
Copy link
ContributorAuthor

alexandre-daubois commentedMar 25, 2025
edited
Loading

I addressed your comments. I'll have a look at what's possible aboutgh attestation verify when I have some time 🙂

@alexandre-dauboisalexandre-dauboisforce-pushed thepie-bin branch 2 times, most recently from4cfd3bc to5820f61CompareMarch 26, 2025 07:56
@tucksaun
Copy link
Member

I'll have a look at what's possible aboutgh attestation verify when I have some time 🙂

PIE is quite cutting-edge as of now so I think we can merge as-is and address this in the coming days/weeks.

OskarStark reacted with thumbs up emoji

@tucksauntucksaun merged commitb3e8467 intosymfony-cli:mainMar 30, 2025
1 check passed
@tucksaun
Copy link
Member

Thank you@alexandre-daubois !

@OskarStark
Copy link

OskarStark commentedMar 30, 2025
edited
Loading

Can we have any docs 🙃?

alexandre-daubois reacted with thumbs up emoji

@alexandre-daubois
Copy link
ContributorAuthor

I'm not sure where we should add this. I would have go forhttps://symfony.com/doc/current/setup/symfony_server.html, but "Symfony Local Web Server" doesn't seem suitable. However it seems the only place we could add this type of doc? Maybe a whole section to wrappers should be added also.

@tucksaun
Copy link
Member

I'm not sure where we should add this. I would have go forhttps://symfony.com/doc/current/setup/symfony_server.html, but "Symfony Local Web Server" doesn't seem suitable. However it seems the only place we could add this type of doc? Maybe a whole section to wrappers should be added also.

I started to talk about this with a couple of people and I believe we should introduce a dedicated documentation for the CLI with the more advanced options and only have an introduction in the Framework doc (with a link to the dedicated one).

This could also help with the fact that currently the documentation for the CLI does not take the CLI version into account because it is being embedded in the Framework documentation.

WDYT?

@alexandre-daubois
Copy link
ContributorAuthor

100% agree, I'm pretty sure many (most?) people underuse Symfony CLI because there's no clear dedicated page to it. Let's create an issue in symfony-docs 🙂

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@tucksauntucksauntucksaun approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexandre-daubois@tucksaun@OskarStark@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp