Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork125
Add first integration tests#435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| for _, command := range startCommands { | ||
| cmd := exec.Command(strings.Split(command, " ")[0], strings.Split(command, " ")[1:]...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
to get more control I would rather directly use the code here (starting the server in a goroutine and issuing http request, worst case: starting the application instead of directly the HTTP server).
alexandre-dauboisFeb 16, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would you do this in all functional tests or only this one? About issuing HTTP request, it is only relevant for starting and stopping the server (and not listing running ones), right?
tucksaun commentedFeb 16, 2024
thank you for starting the work on this! |
43d4ba3 to6429d55Compare
After a quick chat with@tucksaun, here's a try on adding a few integration tests. I only added a few ones to validate the way of doing this before going further. 🙂