Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork125
feat: add an option to create a new project using Symfony Docker#411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
weaverryan commentedJan 15, 2024
I’m not qualified to review technically, but this is exactly what I had in mind. It will help with discoverability.
That’s super interesting! |
sarim commentedJan 18, 2024
please excuse my interjection as I'm not a core team member, but I'd like to share some thoughts on the proposed I apologize again for intruding on a core team discussion. |
weaverryan commentedJan 19, 2024
Hi! Valid points! From a practical point of view, I’m not sure we can maintain 2 different docker skeletons. And so, the one will be opinionated.
Being under the symfony org makes sense to me. But@dunglas is the one doing the maintaining of the docker skeleton in reality. But yea, I think it’d be cool to have it under the symfony org if it’s the official option. |
dunglas commentedJan 29, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@sarim Unfortunately, FPM is not well suited to containerized platforms. This is one of the main reasons I started working on FrankenPHP: to easily distribute Symfony applications as Docker images, as easily as with Node or Go. As a "Symfony Docker" maintainer for years (who used NGINX and FPM in the early days), I can guarantee that using Caddy and then FrankenPHP has simplified a lot of things and greatly improved the developer's experience. I gave [a full presentation on this topic] (https://dunglas.dev/2022/10/frankenphp-the-modern-php-app-server-written-in-go/) at SymfonyCon 2022. @weaverryan I'm not against moving Symfony Docker under the Symfony namespace, as long as we can continue to grant maintenance rights to@maxhelias, who has done a great job maintaining it for a very long time. |
Uh oh!
There was an error while loading.Please reload this page.
The Core Team privately discussed repurposing the
--dockerflag of thesymfony newcommand to create a project usingSymfony Docker. The goals are to have an official way to bootstrap a project using Docker with ease and to set upFrankenPHP with Symfony.This patch only covers project creation.
In the feature, it could be nice also to detect if Symfony Docker is used and forward
symfony console,symfony composer, and similar commands to the Docker container.Usage:
symfony new --dockercc@weaverryan