Commit44e28e3

committed

bug #22866 [DI] Check for privates before shared services (ro0NL)

This PR was merged into the 3.2 branch.Discussion----------[DI] Check for privates before shared services| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |symfony/symfony#22801 (comment),symfony/symfony#22801 (comment)| License | MIT| Doc PR | symfony/symfony-docs#... cc@stofCommits-------4f683a9a5b [DI] Check for privates before shared services

2 parents4701cbf +4794f4f commit44e28e3Copy full SHA for 44e28e3

File tree

1 file changed

-2

lines changed

Tests/DependencyInjection
- WebProfilerExtensionTest.php

1 file changed

-2

lines changed

`‎Tests/DependencyInjection/WebProfilerExtensionTest.php‎`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,10 +27,13 @@ class WebProfilerExtensionTest extends TestCase`
`27`	`27`	`*/`
`28`	`28`	`private$container;`
`29`	`29`
`30`		`-publicstaticfunctionassertSaneContainer(Container$container,$message ='')`
	`30`	`+publicstaticfunctionassertSaneContainer(Container$container,$message ='',$knownPrivates =array())`
`31`	`31`	`{`
`32`	`32`	`$errors =array();`
`33`	`33`	`foreach ($container->getServiceIds()as$id) {`
	`34`	`+if (in_array($id,$knownPrivates,true)) {// to be removed in 4.0`
	`35`	`+continue;`
	`36`	`+ }`
`34`	`37`	`try {`
`35`	`38`	`$container->get($id);`
`36`	`39`	`}catch (\Exception$e) {`
`@@ -98,7 +101,7 @@ public function testToolbarConfig($toolbarEnabled, $interceptRedirects, $listene`
`98`	`101`
`99`	`102`	`$this->assertSame($listenerInjected,$this->container->has('web_profiler.debug_toolbar'));`
`100`	`103`
`101`		`-$this->assertSaneContainer($this->getDumpedContainer());`
	`104`	`+$this->assertSaneContainer($this->getDumpedContainer(),'',array('web_profiler.csp.handler'));`
`102`	`105`
`103`	`106`	`if ($listenerInjected) {`
`104`	`107`	`$this->assertSame($listenerEnabled,$this->container->get('web_profiler.debug_toolbar')->isEnabled());`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit44e28e3

File tree

1 file changed

1 file changed

`‎Tests/DependencyInjection/WebProfilerExtensionTest.php‎`

0 commit comments