Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Link to proxy configuration docs from the routing scheme page#9924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Link to proxy configuration docs from the routing scheme page#9924
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@colinodell I like your contribution, but I reworded it slightly to make it look less like a Symfony problem and more like a user/config problem. Thanks!
| Forcing HTTPS while using a reverse proxy or load balancer requires a proper | ||
| configuration to avoid infinite redirect loops; see:doc:`/deployment/proxies` | ||
| for more details. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this blank line should be removed, but we can do that while merging
| ..note:: | ||
| Forcing HTTPS while using a reverse proxy or load balancer requires a proper | ||
| configuration to avoid infinite redirect loops; see:doc:`/deployment/proxies` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"redirection loops"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Chrome uses "redirect loop" in its error message:
colinodell commentedJun 18, 2018
Thanks@javiereguiluz! 👍 |
javiereguiluz commentedJun 18, 2018
Thanks Colin! This is now merged (in 2.8, which is now the oldest maintained branch) |
…page (colinodell, javiereguiluz)This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes#9924).Discussion----------Link to proxy configuration docs from the routing scheme pageThis should help developers avoid infinite redirect loops.Seesymfony/symfony#27603Commits-------671e13c Reword and added a notec717e75 Link to proxy configuration docs from the routing scheme page
This should help developers avoid infinite redirect loops.
Seesymfony/symfony#27603