Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[DependencyInjection] Document ServiceSubscriberTrait#9809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedMay 27, 2018
What about adding a sentence to tell why this is nice? (Autocompletion mostly isn't it?) |
| provided that takes the class name and method name as arguments:: | ||
| // src/AppBundle/MyService.php | ||
| namespace AppBundle; |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
bundle-less up to 4.0, should be:
// src/MyService.phpnamespaceApp;
2b9e556 to0de578bCompareMemberAuthor
kbond commentedMay 31, 2018
I added an example showing how to create composable traits and a note about not using |
symfony-splitter pushed a commit to symfony/dependency-injection that referenced this pull requestJun 4, 2018
This PR was squashed before being merged into the 4.2-dev branch (closes #27077).Discussion----------[DependencyInjection] add ServiceSubscriberTrait| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #23898| License | MIT| Doc PR |symfony/symfony-docs#9809This allows you to easily configure Service Subscribers with the following convention:```phpclass MyService implements ServiceSubscriberInterface{ use ServiceSubscriberTrait; public function doSomething() { // $this->router() ... } private function router(): RouterInterface { return $this->container->get(__METHOD__); }}```This also allows you to create helper traits like `RouterAware`, `LoggerAware` etc... and compose your services with them (*not* using `__METHOD__` in traits because it doesn't behave as expected.).```phptrait LoggerAware{ private function logger(): LoggerInterface { return $this->container->get(__CLASS__.'::'.__FUNCTION__); }}``````phptrait RouterAware{ private function router(): RouterInterface { return $this->container->get(__CLASS__.'::'.__FUNCTION__); }}``````phpclass MyService implements ServiceSubscriberInterface{ use ServiceSubscriberTrait, LoggerAware, RouterAware; public function doSomething() { // $this->router() ... // $this->logger() ... }}```Commits-------238e793431 [DependencyInjection] add ServiceSubscriberTrait
nicolas-grekas added a commit to symfony/symfony that referenced this pull requestJun 4, 2018
This PR was squashed before being merged into the 4.2-dev branch (closes#27077).Discussion----------[DependencyInjection] add ServiceSubscriberTrait| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23898| License | MIT| Doc PR |symfony/symfony-docs#9809This allows you to easily configure Service Subscribers with the following convention:```phpclass MyService implements ServiceSubscriberInterface{ use ServiceSubscriberTrait; public function doSomething() { // $this->router() ... } private function router(): RouterInterface { return $this->container->get(__METHOD__); }}```This also allows you to create helper traits like `RouterAware`, `LoggerAware` etc... and compose your services with them (*not* using `__METHOD__` in traits because it doesn't behave as expected.).```phptrait LoggerAware{ private function logger(): LoggerInterface { return $this->container->get(__CLASS__.'::'.__FUNCTION__); }}``````phptrait RouterAware{ private function router(): RouterInterface { return $this->container->get(__CLASS__.'::'.__FUNCTION__); }}``````phpclass MyService implements ServiceSubscriberInterface{ use ServiceSubscriberTrait, LoggerAware, RouterAware; public function doSomething() { // $this->router() ... // $this->logger() ... }}```Commits-------238e793 [DependencyInjection] add ServiceSubscriberTrait
tgalopin approved these changesJun 5, 2018
HeahDude approved these changesJun 10, 2018
Member
javiereguiluz commentedJun 11, 2018
@kbond thanks for contributing these docs (and the original feature too). I love it because it explains things perfectly! |
javiereguiluz added a commit that referenced this pull requestJun 11, 2018
…ond)This PR was merged into the master branch.Discussion----------[DependencyInjection] Document ServiceSubscriberTraitDocumentation forsymfony/symfony#27077Commits-------b0ac3a4 document ServiceSubscriberTrait
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation forsymfony/symfony#27077