Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Reference][Form] Describe the syntax of format option using a link of DateTimeType#9788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedMay 17, 2018
Let's ping@vudaltsov as a Symfony Form expert to help us here. The PHPdoc of the DateTimeType class has a lot of information. Also, the ticket opened at ICU project was answered six years ago:http://icu-project.org/trac/ticket/9421 Can we review the PHPdoc of DateTimeType and see if it's still relevant or outdated? Thanks! |
elementaire commentedMay 17, 2018
The same link is used inDateType andBirthdayType docs. It comes fromthis template of this documentation. Depends on the answer of@vudaltsov, maybe it should be updated too. |
vudaltsov commentedMay 17, 2018
@javiereguiluz , I think we should create a separate issue to see if the PHPdoc is still relevant. |
javiereguiluz commentedMay 17, 2018
Thanks for this improvement and congrats on your first Symfony Docs contribution! Thanks to reviewers too! |
…ing a link of DateTimeType (elementaire)This PR was merged into the 2.7 branch.Discussion----------[Reference][Form] Describe the syntax of format option using a link of DateTimeTypeI've added a link to describe how to write a valid format. It is the same link from date and birthday types.Commits-------8b361ef Update datetime.rst
elementaire commentedMay 19, 2018
Should i do something for this to be merged in recent versions of docs too? |
javiereguiluz commentedMay 20, 2018
@elementaire there's no need to create new PRs. From time to time we merge all changes into the upper (maintained) branches. I've just do that, so your change is now in 2.7, 2.8, 3.4, 4.0, 4.1 and master. In a few hours, when symfony.com docs get rebuilt and caches expire, your change will be published. Cheers! |
elementaire commentedMay 20, 2018
Great :) |
Uh oh!
There was an error while loading.Please reload this page.
I've added a link to describe how to write a valid format. It is the same link from date and birthday types.