Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Reference][Form] Describe the syntax of format option using a link of DateTimeType#9788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:2.7fromelementaire:patch-1
May 17, 2018

Conversation

@elementaire
Copy link
Contributor

@elementaireelementaire commentedMay 16, 2018
edited
Loading

I've added a link to describe how to write a valid format. It is the same link from date and birthday types.

alexismarquis reacted with thumbs up emoji
@elementaireelementaire changed the titleUpdate datetime.rst[Reference][Form] Describe the syntax of format option using a link of DateTimeTypeMay 17, 2018
@javiereguiluz
Copy link
Member

Let's ping@vudaltsov as a Symfony Form expert to help us here. The PHPdoc of the DateTimeType class has a lot of information. Also, the ticket opened at ICU project was answered six years ago:http://icu-project.org/trac/ticket/9421 Can we review the PHPdoc of DateTimeType and see if it's still relevant or outdated? Thanks!

@elementaire
Copy link
ContributorAuthor

The same link is used inDateType andBirthdayType docs. It comes fromthis template of this documentation. Depends on the answer of@vudaltsov, maybe it should be updated too.

@vudaltsov
Copy link
Contributor

@javiereguiluz , I think we should create a separate issue to see if the PHPdoc is still relevant.
What@elementaire proposed can be done in any case.

javiereguiluz reacted with thumbs up emoji

@javiereguiluzjaviereguiluz added this to the2.7 milestoneMay 17, 2018
@javiereguiluz
Copy link
Member

Thanks for this improvement and congrats on your first Symfony Docs contribution! Thanks to reviewers too!

vudaltsov reacted with heart emoji

@javiereguiluzjaviereguiluz merged commit8b361ef intosymfony:2.7May 17, 2018
javiereguiluz added a commit that referenced this pull requestMay 17, 2018
…ing a link of DateTimeType (elementaire)This PR was merged into the 2.7 branch.Discussion----------[Reference][Form] Describe the syntax of format option using a link of DateTimeTypeI've added a link to describe how to write a valid format. It is the same link from date and birthday types.Commits-------8b361ef Update datetime.rst
@elementaire
Copy link
ContributorAuthor

Should i do something for this to be merged in recent versions of docs too?

@javiereguiluz
Copy link
Member

@elementaire there's no need to create new PRs. From time to time we merge all changes into the upper (maintained) branches. I've just do that, so your change is now in 2.7, 2.8, 3.4, 4.0, 4.1 and master. In a few hours, when symfony.com docs get rebuilt and caches expire, your change will be published. Cheers!

@elementaire
Copy link
ContributorAuthor

Great :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@vudaltsovvudaltsovvudaltsov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

4 participants

@elementaire@javiereguiluz@vudaltsov@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp