Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Update BC policy to tell about adding/removing return types#9717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| Changing an argument type is only possible with a parent type. | ||
| Changing a return type is only possible with a child type. | ||
| .. [9]Allowed for the ``void`` return type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Are you saying thatvoid is an exception then? That, for example, adding/removing a return type would be a BC break...except for void?
nicolas-grekasMay 2, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, that's what I mean. Technically, PHP allows removing the return type without breaking children. But doing so would allow breaking contracts. Except for void.
javiereguiluz commentedMay 15, 2018
Thanks Nicolas. |
Fixes#8609