Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[LDAP] Add docs for applyOperations method#9715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ablae)This PR was merged into the 4.2-dev branch.Discussion----------[LDAP] Add "applyOperations" method to EntryManager| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #27039| License | MIT| Doc PR |symfony/symfony-docs#9715This PR adds a new method called `applyOperations` to the LDAP `EntryManager` class.Internally it is mapping the new `UpdateOperation` object to the `ldap_modify_batch` method.Tests green against openldap.Thanks for any feedback.Todo: * [x] Add Docs PRCommits-------8fc09c73c6 Add applyOperations batch method to EntryManager
…ablae)This PR was merged into the 4.2-dev branch.Discussion----------[LDAP] Add "applyOperations" method to EntryManager| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#27039| License | MIT| Doc PR |symfony/symfony-docs#9715This PR adds a new method called `applyOperations` to the LDAP `EntryManager` class.Internally it is mapping the new `UpdateOperation` object to the `ldap_modify_batch` method.Tests green against openldap.Thanks for any feedback.Todo: * [x] Add Docs PRCommits-------8fc09c7 Add applyOperations batch method to EntryManager
| Use the EntryManager's ``applyOperations()`` method to update multiple attributes at once:: | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
one blank line is enough :)
components/ldap.rst Outdated
| Batch Updating | ||
| ______________ | ||
| Use the EntryManager's ``applyOperations()`` method to update multiple attributes at once:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[...] entry manager's [...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
and we could use themethod role here:
:method:`Symfony\\Component\\Ldap\\Adapter\\ExtLdap\\EntryManager::applyOperations`
components/ldap.rst Outdated
| new UpdateOpteration(LDAP_MODIFY_BATCH_ADD, 'mail', 'new2@example.com'), | ||
| )); | ||
| Possible operation types are ``LDAP_MODIFY_BATCH_ADD``, ``LDAP_MODIFY_BATCH_REMOVE``, ``LDAP_MODIFY_BATCH_REMOVE_ALL``, ``LDAP_MODIFY_BATCH_REPLACE``. Parameter ``$values`` must be ``NULL`` when using ``LDAP_MODIFY_BATCH_REMOVE_ALL`` operation type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we usually split lines after the first word that crosses the 72nd character
components/ldap.rst Outdated
| Possible operation types are ``LDAP_MODIFY_BATCH_ADD``, ``LDAP_MODIFY_BATCH_REMOVE``, ``LDAP_MODIFY_BATCH_REMOVE_ALL``, ``LDAP_MODIFY_BATCH_REPLACE``. Parameter ``$values`` must be ``NULL`` when using ``LDAP_MODIFY_BATCH_REMOVE_ALL`` operation type. | ||
| ..versionadded::4.2 | ||
| The ``applyOperations()`` was introduced in Symfony 4.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TheapplyOperations() method [...]
mablae commentedMay 19, 2018
Thanks@xabbuh . I just applied your fixes and rebased it. |
javiereguiluz commentedMay 22, 2018
Malte, thanks for contributing this feature to Symfony and for providing the docs for it. Also, it was the first Symfony Docs contribution, so thank you and congrats! |
This PR was merged into the master branch.Discussion----------[LDAP] Add docs for applyOperations methodSee PRsymfony/symfony#27069Commits-------74fed75 [LDAP] Add docs for applyOperations method
See PRsymfony/symfony#27069