Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Finder] Described "use natural sort" option#9671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
symfony-splitter pushed a commit to symfony/finder that referenced this pull requestMay 30, 2018
This PR was merged into the 4.2-dev branch.Discussion----------[Finder] added "use natural sort" option| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #26930| License | MIT| Doc PR |symfony/symfony-docs#9671Added `$useNaturalSort` optional argument to `Finder::sortByName()` method. If it is specified and equals to `true`, ["natural sort order" algorithm](https://en.wikipedia.org/wiki/Natural_sort_order) will be applied, which means that `strnatcmp` function will be used instead of `strcmp` (see #26930 for details).Commits-------e697c7d272 [Finder] added "use natural sort" option
fabpot added a commit to symfony/symfony that referenced this pull requestMay 30, 2018
This PR was merged into the 4.2-dev branch.Discussion----------[Finder] added "use natural sort" option| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#26930| License | MIT| Doc PR |symfony/symfony-docs#9671Added `$useNaturalSort` optional argument to `Finder::sortByName()` method. If it is specified and equals to `true`, ["natural sort order" algorithm](https://en.wikipedia.org/wiki/Natural_sort_order) will be applied, which means that `strnatcmp` function will be used instead of `strcmp` (see#26930 for details).Commits-------e697c7d [Finder] added "use natural sort" option
ContributorAuthor
vyshkant commentedMay 31, 2018
Looks like code has been merged. |
javiereguiluz approved these changesJun 1, 2018
Member
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@vyshkant thanks for providing these docs. I loved that you made it so concise ... but to avoid confusion, I expanded the explanation a bit to show an example. Thanks!
Member
javiereguiluz commentedJun 1, 2018
And this is now merged! The first merge for Symfony 4.2 🎉@vyshkant congrats on your first Symfony Docs contribution too! |
javiereguiluz added a commit that referenced this pull requestJun 1, 2018
…aviereguiluz)This PR was merged into the master branch.Discussion----------[Finder] Described "use natural sort" optionAdded description for new `$useNaturalSort` option of `Finder::sortByName()` method.Commits-------9649800 Expanded the explanation a bit0d38d1b [Finder] Described "use natural sort" option
joshtrichards pushed a commit to joshtrichards/symfony-finder that referenced this pull requestApr 26, 2024
This PR was merged into the 4.2-dev branch.Discussion----------[Finder] added "use natural sort" option| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #26930| License | MIT| Doc PR |symfony/symfony-docs#9671Added `$useNaturalSort` optional argument to `Finder::sortByName()` method. If it is specified and equals to `true`, ["natural sort order" algorithm](https://en.wikipedia.org/wiki/Natural_sort_order) will be applied, which means that `strnatcmp` function will be used instead of `strcmp` (see #26930 for details).Commits-------16aff97 [Finder] added "use natural sort" option
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Added description for new
$useNaturalSortoption ofFinder::sortByName()method.