Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[VarDumper] Fix rendering of inline code#9605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[VarDumper] Fix rendering of inline code#9605
Conversation
javiereguiluz commentedApr 16, 2018
This is tricky. We did this on purpose because the Maybe we can fix this with a little reword: * A bit field of ``EXCLUDE_*`` constants from the:class:`Symfony\\Component\\VarDumper\\Caster\\Caster` class. |
kevin-verschaeve commentedApr 16, 2018
Oh I see. Yes we can do as you propose or keep as it is but removing some unwanted backquotes
See, there is twice 2 backquotes that prevent the rendering and complicate reading. We can just remove them. Tell me, what is the best, I will update the PR |
…ning of the First Example page (Lyrkan)This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closessymfony#9526).Discussion----------[Encore] Don't enable the Sass loader at the beginning of the First Example pageSomeone pointed out insymfony/webpack-encore#287 that if you follow the [First example](http://symfony.com/doc/master/frontend/encore/simple-example.html) page from top to bottom you are going to run `yarn encore` before being informed that calling `enableSassLoader()` implies adding additional dependencies (which is done just after).~~This PR moves the related paragraph to warn the user that Encore will tell him about missing packages before he encounters the error.~~~~I also added the "after running it" part to make it a bit more obvious that the information is going to be present in the command output.~~**Edit:** Changed it so `enableSassLoader()` is commented before running Encore for the first timeCommits-------18586e2 [Encore] Don't enable the Sass loader at the beginning of the First Example page
0d5bc47 to15ef727Comparekevin-verschaeve commentedApr 16, 2018
@javiereguiluz it seems that just adding a space fix the issue :) |
15ef727 to8389469Comparejaviereguiluz commentedApr 16, 2018
I like your solution! Let's merge it (on 3.4 branch). Thanks! |
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes#9605).Discussion----------[VarDumper] Fix rendering of inline codeA small piece of code that is not rendered correctly on the varDumper componentCommits-------8389469 [VarDumper] Fix rendering of inline code
A small piece of code that is not rendered correctly on the varDumper component