Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Form] Fixed ChoiceType trim option#9598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This PR was merged into the 2.7 branch.Discussion----------[Form] Fixed trimming choice values| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24247,#24712| License | MIT| Doc PR |symfony/symfony-docs#9598Follows#24712 discussion.Commits-------00cdf5e [Form] Fixed trimming choice values
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice! Thanks Jules.
HeahDude commentedApr 18, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thank you for the rewording 👍 |
reference/forms/types/choice.rst Outdated
| the parent field (the form in most cases). | ||
| trim | ||
| ~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we should move the description to its own file to be able to reuse it in other form types. This is currently missing in some documents (see the failing build).
wouterj commentedMay 5, 2018
reference/forms/types/choice.rst Outdated
| | Overridden| - `compound`_| | ||
| | options| - `empty_data`_| | ||
| || - `error_bubbling`_| | ||
| || - `choice_type_trim`_| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
here we would still have to usetrim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Was not sure ^^. Fixed, thanks!
| **type**: ``boolean``**default**: ``false`` | ||
| Trimming is disabled by default because the selected valueor values must match | ||
| the given choice valuesexactly (and they could contain white spaces). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"whitespaces" (without the space)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Agreed, fixed. Thanks again!
wouterj commentedMay 8, 2018
Thanks Jules. |
…uiluz)This PR was merged into the 2.7 branch.Discussion----------[Form] Fixed ChoiceType trim optionRefsymfony/symfony#26932.Commits-------2dd6c56 fixup typo360066d fixup option links6631665 fixup@xabbuh's comment proper choice type trim file8bfa059 Rewordbbca3b0 [Form] Fixed ChoiceType trim option
Refsymfony/symfony#26932.