Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Document the DotEnv::overload() method#9568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fabpot added a commit to symfony/symfony that referenced this pull requestSep 4, 2018
This PR was merged into the 4.2-dev branch.Discussion----------[Dotenv] add a flag to allow env vars override| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#26846| License | MIT| Doc PR |symfony/symfony-docs#9568I choose to use a new parameter in the constructor instead of `populate()` to not add boilerplate code to them who want allow overriding in their current setup. It's just a parameter to add in `Dotenv` creation instead of change or customize the loading of different .env files.I targeted 4.1 despite the feature freeze because it's a small change but if you don't agree I can change to 4.2.~~If you accept this PR I will do the doc PR then.~~doc readyCommits-------228b220 [Dotenv] add Dotenv::overload() to allow env vars override
ContributorAuthor
fmata commentedSep 4, 2018
Code merged, doc ready. |
Member
javiereguiluz commentedSep 4, 2018
@fmata thanks a lot for this contribution! Another lovely addition to Symfony 4.2. I reworded the doc a bit to not mention |
javiereguiluz added a commit that referenced this pull requestSep 4, 2018
…luz)This PR was merged into the master branch.Discussion----------Document the DotEnv::overload() methodI'm not sure how to update the doc according my PRsymfony/symfony#26859 which is pending review but feel free to comment if I did a mistake. Thank you.Commits-------38e4f08 Rewordf8a3c0d Update dotenv.rst6325759 Update dotenv.rstc8ad296 Update dotenv.rst
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure how to update the doc according my PRsymfony/symfony#26859 which is pending review but feel free to comment if I did a mistake. Thank you.