Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Security] add tip about using custom functions#9552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Merged
4 tasks
fabpot added a commit to symfony/symfony that referenced this pull requestApr 6, 2018
…low_if expressions (dmaicher)This PR was merged into the 4.1-dev branch.Discussion----------[SecurityBundle] allow using custom function inside allow_if expressions| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | no| Fixed tickets |#23208| License | MIT| Doc PR |symfony/symfony-docs#9552This is a follow-up for#26263As discussed there I propose to allow using custom functions as a new feature only and thus targeting `master` here.If we agree to move forward with this there are some todos:- [x] fix tests- [x] add cache warmer for allow_if expressions- [x] update documentation to mention this new feature- [x] update UPGRADE filesping@nicolas-grekas@stofCommits-------41552cd [SecurityBundle] allow using custom function inside allow_if expressions
Member
javiereguiluz commentedApr 19, 2018
Thanks David. |
javiereguiluz added a commit that referenced this pull requestApr 19, 2018
…, javiereguiluz)This PR was merged into the master branch.Discussion----------[Security] add tip about using custom functionsSince 4.1 its possible to use custom functions inside security `allow_if` expressions.Seesymfony/symfony#26660Commits-------44708ad Reword8a96822 [Security] add tip about using custom functions
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Since 4.1 its possible to use custom functions inside security
allow_ifexpressions.Seesymfony/symfony#26660