Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

rounding_mode for money type#9543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@syastrebov
Copy link
Contributor

@syastrebovsyastrebov commentedApr 3, 2018•
edited
Loading

Added docs forsymfony/symfony#26767

@syastrebovsyastrebovforce-pushed theset-money-rounding-mode branch 4 times, most recently froma015ecc to47954feCompareApril 3, 2018 15:59
@javiereguiluzjaviereguiluz added the Waiting Code MergeDocs for features pending to be merged labelApr 4, 2018
fabpot added a commit to symfony/symfony that referenced this pull requestApr 4, 2018
…(syastrebov)This PR was merged into the 4.1-dev branch.Discussion----------[Form] ability to set rounding strategy for MoneyType| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | no| License       | MIT| Doc PR        |symfony/symfony-docs#9543Added `rounding_mode` to the `MoneyType` to be possible to change rounding strategy for money values. For now it's just `ROUND_HALF_UP` but it's good to have `ROUND_DOWN` as well. E.g. to transform `15.999` to `15.99` instead of `15.1`.Commits-------f3b1424 rounding_mode for money type
@xabbuhxabbuh removed the Waiting Code MergeDocs for features pending to be merged labelApr 10, 2018
@xabbuhxabbuh added this to the4.1 milestoneApr 10, 2018
+-------------+---------------------------------------------------------------------+
| Options| - `currency`_|
|| - `divisor`_|
|| - `rounding_mode`_|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should be aftergrouping IMO to sort the options alphabetically

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@xabbuh done

@syastrebovsyastrebovforce-pushed theset-money-rounding-mode branch from47954fe to268e439CompareApril 11, 2018 09:40
@syastrebovsyastrebovforce-pushed theset-money-rounding-mode branch from268e439 to819d0a6CompareApril 11, 2018 09:42
@javiereguiluz
Copy link
Member

@syastrebov thanks a lot for contributing these missing docs. It was a great first contribution to Symfony Docs!

@javiereguiluzjaviereguiluz merged commit819d0a6 intosymfony:masterApr 16, 2018
javiereguiluz added a commit that referenced this pull requestApr 16, 2018
This PR was merged into the master branch.Discussion----------rounding_mode for money typeAdded docs forsymfony/symfony#26767Commits-------819d0a6 rounding_mode for money type
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@syastrebov@javiereguiluz@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp