Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Encore] Don't enable the Sass loader at the beginning of the First Example page#9526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
24bd2de toc0cfd35Compareweaverryan commentedMar 31, 2018
I also think the report is legit@Lyrkan. But, what about commenting out all of the features that require extra packages so that the first build is successful? Then we can show an example of uncommenting the |
c0cfd35 tob071ed2CompareLyrkan commentedMar 31, 2018
@weaverryan I agree, should be better now :) |
b071ed2 to18586e2Comparejaviereguiluz commentedApr 16, 2018
@Lyrkan this was a great first contribution to Symfony Docs! Thanks a lot. |
… the First Example page (Lyrkan)This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes#9526).Discussion----------[Encore] Don't enable the Sass loader at the beginning of the First Example pageSomeone pointed out insymfony/webpack-encore#287 that if you follow the [First example](http://symfony.com/doc/master/frontend/encore/simple-example.html) page from top to bottom you are going to run `yarn encore` before being informed that calling `enableSassLoader()` implies adding additional dependencies (which is done just after).~~This PR moves the related paragraph to warn the user that Encore will tell him about missing packages before he encounters the error.~~~~I also added the "after running it" part to make it a bit more obvious that the information is going to be present in the command output.~~**Edit:** Changed it so `enableSassLoader()` is commented before running Encore for the first timeCommits-------18586e2 [Encore] Don't enable the Sass loader at the beginning of the First Example page
Uh oh!
There was an error while loading.Please reload this page.
Someone pointed out insymfony/webpack-encore#287 that if you follow theFirst example page from top to bottom you are going to run
yarn encorebefore being informed that callingenableSassLoader()implies adding additional dependencies (which is done just after).This PR moves the related paragraph to warn the user that Encore will tell him about missing packages before he encounters the error.I also added the "after running it" part to make it a bit more obvious that the information is going to be present in the command output.Edit: Changed it so
enableSassLoader()is commented before running Encore for the first time