Fixes deprecated ProcessBuilder usage#9395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

guillbdx wants to merge1 commit intosymfony:4.0fromguillbdx:patch-2

Closed

Fixes deprecated ProcessBuilder usage#9395

guillbdx wants to merge1 commit intosymfony:4.0fromguillbdx:patch-2

Conversation

Copy link

guillbdx commentedMar 5, 2018

No description provided.

Fixes deprecated ProcessBuilder usage

37362c6

carsonbot added the Status: Needs Review label

Mar 5, 2018

Copy link

Contributor

Simperfit commentedMar 6, 2018

This one is not needed, the documentation team will take care of merging the 3.4 branch in the 4.0 and master branch ;).

Thanks for the contribution anyway!

Copy link

Member

xabbuh commentedMar 6, 2018

@guillbdx Thank you for the PR, but as@Simperfit said we regularly merge branches up. :)

xabbuh closed this

Mar 6, 2018

Copy link

Member

javiereguiluz commentedMar 6, 2018

@guillbdx thanks for your contribution! As others said, we regularly merge changes from lower to upper branches until we reachmaster, so this shouldn't be needed.

But I can't remember a recent pull request that made these changes and was merged in lower branches ... so this may be a problem that won't be fixed waiting for the upper branches merges. I'm reopening so we can look closely at this. Thanks!

javiereguiluz reopened this

Mar 6, 2018

Copy link

Contributor

Simperfit commentedMar 6, 2018 via email

There is a open PR with the sames change targeting 3.4Le mar. 6 mars 2018 à 11:26, Javier Eguiluz <notifications@github.com> aécrit :

…

@guillbdx <https://github.com/guillbdx> thanks for your contribution! As others said, we regularly merge changes from lower to upper branches until we reach master, so this shouldn't be needed. But I can't remember a recent pull request that made these changes and was merged in lower branches ... so this may be a problem that won't be fixed waiting for the upper branches merges. I'm reopening so we can look closely at this. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9395 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADSq8uxkCM9Gh87Rwl3MmlD3gVBIPBNxks5tbmRTgaJpZM4Sd0Vp> .