Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Use symfony/skeleton to show the welcome page again#9333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
If you create the symfony/website-skeleton as suggested in the docs you won't see the welcome page as stated later on this page ("If everything is working, you'll see a welcome page") but a 404 error, because of the routes the profiler generates.(see alsohttps://stackoverflow.com/questions/48643561/symfony-4-setup-issues-router-exception/48647114#48647114)Also on the 'next' page "Create your First Page in Symfony" the installation of the profiler is suggested which is already installed with the symfony/website-skeleton.javiereguiluz commentedFeb 25, 2018
@PeterMarteau thanks for your first contribution to this repository. You are 100% correct about this. Using the skeleton instead of the website-skeleton would display the Welcome Page. However, that would "break" other things because in the docs we suppose that you are using the website-skeleton, so we'd need to change a lot of other things. The best solution to this is to always display the Welcome Page, no matter if you use the skeleton or website-skeleton. There's a pull request to fix that:symfony/symfony#26041 I'll try to finish it soon. That's why I'm closing this pull request and I hope you understand it. Also, we're looking forward to receive more contributions from you in the future. Thanks! |
If you create the symfony/website-skeleton as suggested in the docs you won't see the welcome page as stated later on this page ("If everything is working, you'll see a welcome page") but a 404 error, because of the routes the profiler generates.
(see alsohttps://stackoverflow.com/questions/48643561/symfony-4-setup-issues-router-exception/48647114#48647114)
Also on the 'next' page "Create your First Page in Symfony" the installation of the profiler is suggested which is already installed with the symfony/website-skeleton.