Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

remove old versionadded directives#9325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:4.0fromxabbuh:versionadded
Feb 23, 2018

Conversation

xabbuh
Copy link
Member

same asd038da7

@xabbuhxabbuh added this to the4.0 milestoneFeb 23, 2018
@xabbuh
Copy link
MemberAuthor

I think we should simplify the process for removingversionadded directives (currently document athttp://symfony.com/doc/current/contributing/documentation/format.html#new-features-or-behavior-changes) and just always drop all existingversionadded directives when a new major version is released. What do you think?

javiereguiluz reacted with thumbs up emoji

javiereguiluz added a commit that referenced this pull requestFeb 23, 2018
This PR was merged into the 3.4 branch.Discussion----------Fixed a versionadded directiveSpotted while reviewing#9325.Commits-------6be33f6 Fixed a versionadded directive
@javiereguiluz
Copy link
Member

javiereguiluz commentedFeb 23, 2018•
edited
Loading

Thanks Christian! I agree with your proposal about simplifying the removal ofversionadded directives.

@javiereguiluzjaviereguiluz merged commit2a78bb9 intosymfony:4.0Feb 23, 2018
javiereguiluz added a commit that referenced this pull requestFeb 23, 2018
This PR was merged into the 4.0 branch.Discussion----------remove old versionadded directivessame asd038da7Commits-------2a78bb9 remove old versionadded directives
@xabbuhxabbuh deleted the versionadded branchFebruary 23, 2018 20:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

3 participants
@xabbuh@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp