Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[FrameworkBundle] feature: redirect query params too in RedirectController#9314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
routing/redirect_in_config.rst Outdated
| Because you are redirecting to a route instead of a path, the required | ||
| option is called ``route`` in the ``redirect()`` action, instead of ``path`` | ||
| in the ``urlRedirect()`` action. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should be reverted
routing/redirect_in_config.rst Outdated
| '_controller' => 'Symfony\Bundle\FrameworkBundle\Controller\RedirectController::redirectAction', | ||
| 'route' => 'sonata_admin_dashboard', | ||
| 'permanent' => true, | ||
| 'keepQueryParams' => true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The trailing comma in the last element of the arrays is missing, look#8325
Adding documentation for the redirectAction improvement
Simperfit commentedApr 24, 2018
@xabbuh@DylanDelobel done |
routing/redirect_in_config.rst Outdated
| Assume you are migrating your website from WordPress to Symfony, you want to | ||
| redirect ``/wp-admin`` to the route ``sonata_admin_dashboard``. You don't know | ||
| the path, only the route name. This can be achieved using the | ||
| the path, only the route name, if you pass query parameters to this route and active the ``keepQueryParams``, it will be redirected too. This can be achieved using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We usually split lines after the first word that crosses the 72nd character. But we can make that tweak while merging. :)
javiereguiluz commentedApr 26, 2018
Thanks for documenting this new 4.1 feature ... and for implementing the feature too! |
…edirectController (Simperfit, javiereguiluz)This PR was merged into the master branch.Discussion----------[FrameworkBundle] feature: redirect query params too in RedirectControllerAdding documentation for the redirectAction improvement.This needs the feature to be merged firstCommits-------ba5c343 Restored a removed character6c92c05 Reworded the new option explanation7210586 feature: redirect query params too in RedirectController
Adding documentation for the redirectAction improvement.
This needs the feature to be merged first