Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] feature: add the ability to search for a route#9236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:masterfromSimperfit:patch-5
Mar 23, 2018

Conversation

@Simperfit
Copy link
Contributor

The PR add the documentation for core's PRsymfony/symfony#26121

[1] blog_show
>
If you choose ``blog_show`` it will show the route information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about merging this all in the previous code example, to reduce the amount of text/lines?

You can also get very specific information on a single route by includingthe route name as the command argument:..code-block::terminal    $ php bin/console debug:router article_show    # ...    # or use part of the name to search for routes    $ php bin/console debug:router blo      Select one of the following routes to display its information:      [0] blog      [1] blog_show     >

Simperfit reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we can simply drop the sentence. The CLI example is self-explanatory, isn't it?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

what sentence do you want to drop, the one explaining or the one in the comments?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this one: "If you chooseblog_show it will show the route information."

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

done

@wouterj
Copy link
Member

I like the feature! 👍 for when it gets merged

symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestMar 21, 2018
… route (Simperfit)This PR was merged into the 4.1-dev branch.Discussion----------[FrameworkBundle] feature: add the ability to search a route| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets | #26033| License       | MIT| Doc PR        |symfony/symfony-docs#9236This add the ability to search a route in the debug:router command.![img_3271](https://user-images.githubusercontent.com/3451634/36034017-e60cbfda-0db2-11e8-841a-60bc75b0b631.jpeg)Commits-------ef0df02afc [FrameworkBundle] feature: add the ability to search a route
fabpot added a commit to symfony/symfony that referenced this pull requestMar 21, 2018
… route (Simperfit)This PR was merged into the 4.1-dev branch.Discussion----------[FrameworkBundle] feature: add the ability to search a route| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets |#26033| License       | MIT| Doc PR        |symfony/symfony-docs#9236This add the ability to search a route in the debug:router command.![img_3271](https://user-images.githubusercontent.com/3451634/36034017-e60cbfda-0db2-11e8-841a-60bc75b0b631.jpeg)Commits-------ef0df02 [FrameworkBundle] feature: add the ability to search a route
@Simperfit
Copy link
ContributorAuthor

PR is ready, updated with the final merged PR on the core.

@xabbuhxabbuh removed the Waiting Code MergeDocs for features pending to be merged labelMar 21, 2018
@xabbuhxabbuh added this to the4.1 milestoneMar 21, 2018
@javiereguiluz
Copy link
Member

Thanks Hamza.

@javiereguiluzjaviereguiluz merged commit2d781a8 intosymfony:masterMar 23, 2018
javiereguiluz added a commit that referenced this pull requestMar 23, 2018
…a route (Simperfit)This PR was merged into the master branch.Discussion----------[FrameworkBundle] feature: add the ability to search for a routeThe PR add the documentation for core's PRsymfony/symfony#26121Commits-------2d781a8 feature: add the ability to search for a route
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj left review comments

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@Simperfit@wouterj@javiereguiluz@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp