Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Container][Tags] Added a note about _instanceof#9221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ghost wants to merge2 commits intosymfony:3.3fromunknown repository
Closed

[Container][Tags] Added a note about _instanceof#9221

ghost wants to merge2 commits intosymfony:3.3fromunknown repository

Conversation

@ghost
Copy link

Documentation related tosymfony/symfony#21530 and symfony/symfony-docs issue#9089.

I was looking for this yesterday and couldn't find it, so I'm hereby updating the doc.

I was looking for this yesterday and couldn't find it, so I'm hereby updating the doc. This will alsofix#9089.
If you do not want to create a custom kernel, it is also possible to use `_instanceof`:

..code-block::yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Missing the xml and php documentation format. However, I'm unsure of their notations at this point.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note that for PHP, setInstanceofConditionals should be called for every single definition, since there is no "file" scope context there

@javiereguiluzjaviereguiluz modified the milestones:3.1,3.4Apr 19, 2018
@HeahDude
Copy link
Contributor

Hello@ghost! Thanks for working on this! Would you like to add the other config formats or should we take over your PR?

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJul 1, 2018•
edited
Loading

I'd suggest adding a "tips" note stating something like:
While similar on the surface, registerForAuconfiguration() and instanceof-conditionals have different scope. registerForAuconfiguration() defines options that should be applied globally to all the definitions that have autoconfiguration enabled. Instanceof-conditionals apply only to the services defined in the very file where they are defined, whether or not these services have autoconfiguration enabled.

@javiereguiluz
Copy link
Member

This pull request stalled, so I've created#10491 to finish what reviewers asked here. Thanks!

javiereguiluz added a commit that referenced this pull requestOct 15, 2018
This PR was merged into the 3.4 branch.Discussion----------Improved the docs of the instanceof configThis finishes#9221.Commits-------3d256c6 Improved the docs of the instanceof config
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

7 participants

@HeahDude@nicolas-grekas@javiereguiluz@acrobat@linaori@carsonbot@Hipio
[8]ページ先頭
©2009-2025 Movatter.jp