Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add Prefixing the Names of Imported Routes#9186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 2 commits intosymfony:3.4fromismail1432:patch-3
Feb 7, 2018
Merged

add Prefixing the Names of Imported Routes#9186

javiereguiluz merged 2 commits intosymfony:3.4fromismail1432:patch-3
Feb 7, 2018

Conversation

@ismail1432
Copy link
Contributor

This PR follows this one#9159

@javiereguiluz
Copy link
Member

javiereguiluz commentedFeb 2, 2018
edited
Loading

@ismail1432 I've reviewed your contribution and made some fixes. You may be thinking"he changed everything I contributed!!" but I hope you understand why we made those changes:

  • Syntax issues: Symfony Docs use a very strict format called reStructuredText. That's why the underline of a heading must be of the same length of the heading, the code blocks that contain PHP don't need a.. code-block directive, etc.
  • Content issues: the example you took from the blog post was a bit complex (my bad!) so I've simplified the route config to make things easier to understand.
  • Missing.. versionadded directive: it's needed when we document a new feature so the reader knows when a feature was introduced.

In any case, thanks for your contribution and we hope to get more contributions from you in the future. Thanks!

@ismail1432
Copy link
ContributorAuthor

No worries@javiereguiluz ! I totally understand.
Thanks for the feedback

@javiereguiluzjaviereguiluz merged commitf8b8e0d intosymfony:3.4Feb 7, 2018
javiereguiluz added a commit that referenced this pull requestFeb 7, 2018
…aviereguiluz)This PR was merged into the 3.4 branch.Discussion----------add  Prefixing the Names of Imported RoutesThis PR follows this one#9159Commits-------f8b8e0d Some fixes and rewords5ec506d add  Prefixing the Names of Imported Routes
@xabbuhxabbuh added this to the3.4 milestoneFeb 23, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@ismail1432@javiereguiluz@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp