uploading example: explaining the need for md5#9179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

MacDada wants to merge2 commits intosymfony:4.0fromMacDada:patch-4

Closed

uploading example: explaining the need for md5#9179

MacDada wants to merge2 commits intosymfony:4.0fromMacDada:patch-4

Conversation

Copy link

Contributor

MacDada commentedJan 31, 2018•
edited
Loading

Plus extracted function with a name that makes the comment unnecessary.

uploading example: explaining the need for md5

8ef7c12

carsonbot added the Status: Needs Review label

Jan 31, 2018

MacDada mentioned this pull request

Jan 31, 2018

upload example:md5 ofuniqid is unnecessary#9177

Closed

Reword a code comment

5f00f81

javiereguiluz approved these changes

Jan 31, 2018

View reviewed changes

javiereguiluz added Status: Reviewed and removed Status: Needs Review labels

Jan 31, 2018

Copy link

Member

javiereguiluz commentedJan 31, 2018

@MacDada nice improvement! Thank you. This one was merged on 2.7 branch too.

javiereguiluz added a commit that referenced this pull request

Jan 31, 2018

minor#9179uploading example: explaining the need for md5 (MacDada, …

eb637f0

…javiereguiluz)This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes#9179).Discussion----------uploading example: explaining the need for md5Plus extracted function with a name that makes the comment unnecessary.Commits-------9321577 Reword a code comment6185887 uploading example: explaining the need for md5

javiereguiluz closed this

Jan 31, 2018