Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Add the possibility to prefix URLs and routes name#9159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I saw this issue#8358 and I want to solve it but I am not sure if it's the good place to add this information 😀
javiereguiluz commentedJan 31, 2018
@ismail1432 I like this. Thanks for contributing! However, I'd like to propose to change the location of this change. The
If you need any help with this, please tell me. Thanks! |
ismail1432 commentedJan 31, 2018
Ok I'll do that |
javiereguiluz commentedJan 31, 2018
Please don't make any change yet! I think I'm messing things 😅 There are two features (URL prefix, route name prefix) and two different scenarios (config files,@route annotation). In the past we had: URL prefix + config files or@route ... in 3.4 we added route name prefix +@route and in 4.1 we added route name prefix + config files. So, the changes are more complex than I imagined. We'd need to:
So, in this PR you can take care of 2. and we'll finish 1. and 3. in separate PRs. Thank you and I'm sorry for all the trouble. |
ismail1432 commentedJan 31, 2018
Ok, thanks for clarification. |
ismail1432 commentedFeb 1, 2018
Hi@javiereguiluz I create a newPR#9186 for step 2 |
javiereguiluz commentedFeb 11, 2018
Closing as fixed because the three issues are now fixed and merged:
Thanks! |
I saw this issue#8358 and I want to solve it but I am not sure if it's the good place to add this information 😀