Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Add example for Finder::exclude#9158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure we need to show a full example with the full dir structure. I'd say this behavior is what people would expect, so maybe just mentioning that exclude dirs must be relative to the in() dir would be enough.
theofidry left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the change, indeed it's better that way 👍
javiereguiluz commentedJan 29, 2018
Thanks Théo. |
This PR was merged into the 2.7 branch.Discussion----------Add example for Finder::excludeFollow up ofsymfony/symfony#25945Commits-------99b0f7a Reworded the note as a code comment5e96849 Update finder.rst9970d42 Add example for Finder::exclude
Follow up ofsymfony/symfony#25945