Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Revert asset versioning back to SF 3 directory structure#9155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:3.3fromallejo:patch-1
Jan 28, 2018
Merged

Revert asset versioning back to SF 3 directory structure#9155

javiereguiluz merged 1 commit intosymfony:3.3fromallejo:patch-1
Jan 28, 2018

Conversation

@allejo
Copy link
Contributor

I don't believe SF 3 started using thepublic/ directory, right? I think the 3.x docs were updated a bit prematurely since the 3.4 docs are affected too. Should the 3.4 change be another PR or could that be cherry-picked by a maintainer?

@javiereguiluz
Copy link
Member

@allejo thanks for fixing this. You are right because we use the new dir structure starting from 4.0 version, so we must revert this for 3.x versions

@javiereguiluzjaviereguiluz merged commit8c37957 intosymfony:3.3Jan 28, 2018
javiereguiluz added a commit that referenced this pull requestJan 28, 2018
…(allejo)This PR was merged into the 3.3 branch.Discussion----------Revert asset versioning back to SF 3 directory structureI don't believe SF 3 started using the `public/` directory, right? I think the 3.x docs were updated a bit prematurely since the 3.4 docs are affected too. Should the 3.4 change be another PR or could that be cherry-picked by a maintainer?Commits-------8c37957 Revert back to SF 3 directory structure
@javiereguiluz
Copy link
Member

About the 3.4 branch, don't worry because we "merge up" all changes of all branches ... so this will land on 3.4 branch today or tomorrow. Thanks!

@xabbuhxabbuh added this to the3.3 milestoneJan 28, 2018
xabbuh added a commit that referenced this pull requestJan 28, 2018
@xabbuh
Copy link
Member

reverted on the4.0 branch in1045b7b

xabbuh added a commit that referenced this pull requestJan 28, 2018
* 4.0:  [#9155] revert on the 4.0 branch  minor#9152 Fix action name in controller (orions)  Fix passing arguments to "Client" constructor  Fixed the config file name for the other config formats too  Revert back to SF 3 directory structure  typo!  Fix wrong filename  Reword  Update doctrine.rst
@allejoallejo deleted the patch-1 branchJanuary 28, 2018 22:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@allejo@javiereguiluz@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp