Fix passing arguments to "Client" constructor#9149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

liviubalan wants to merge1 commit intosymfony:3.4fromliviubalan:patch-1

Closed

Fix passing arguments to "Client" constructor#9149

liviubalan wants to merge1 commit intosymfony:3.4fromliviubalan:patch-1

Conversation

Copy link

Contributor

liviubalan commentedJan 27, 2018

"Client" is expecting an instance of "CookieJar", not "Cookie"

Fix passing arguments to "Client" constructor

d12616a

"Client" is expecting an instance of "CookieJar", not "Cookie"

carsonbot added the Status: Needs Review label

Jan 27, 2018

javiereguiluz added Status: Reviewed and removed Status: Needs Review labels

Jan 28, 2018

javiereguiluz added this to the2.2 milestone

Jan 28, 2018

Copy link

Member

javiereguiluz commentedJan 28, 2018

@liviubalan thanks for fixing this error! This was wrong since the oldest maintained branch (2.7) so I merged on it. That's why GitHub may make it look as closed instead of merged ... but it's merged.

javiereguiluz added a commit that referenced this pull request

Jan 28, 2018

minor#9149Fix passing arguments to "Client" constructor (liviubalan)

136dadf

This PR was submitted for the 3.4 branch but it was merged into the 2.7 branch instead (closes#9149).Discussion----------Fix passing arguments to "Client" constructor"Client" is expecting an instance of "CookieJar", not "Cookie"Commits-------dc438d2 Fix passing arguments to "Client" constructor

javiereguiluz closed this

Jan 28, 2018