Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update doctrine.rst#9141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
tvlooy wants to merge1 commit intosymfony:4.0fromtvlooy:patch-11
Closed

Update doctrine.rst#9141

tvlooy wants to merge1 commit intosymfony:4.0fromtvlooy:patch-11

Conversation

@tvlooy
Copy link
Contributor

my doctrine.yml had acharset: utf8mb4 but my schema update generated tables with utf8. Seems like there is a separate configuration directive for the tables and this is not inherited from the database

collate:~
path:~
memory:~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just a minor comment: this blank line should be removed (but we can do that while merging)

@xabbuhxabbuh added this to the2.7 milestoneJan 28, 2018
Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To be honest, this looks like a bug or a poor DX in DoctrineBundle. Table charset/collate should be the same as the one configured in the database ... unless you configure the table options explicitly. But maybe I'm missing something here.

@xabbuh
Copy link
Member

For the records, there is a related issues in the DoctrineBundle repo (seedoctrine/DoctrineBundle#766).

my doctrine.yml had a ```charset: utf8mb4``` but my schema update generated tables with utf8. Seems like there is a separate configuration directive for the tables and this is not inherited from the database
@javiereguiluz
Copy link
Member

@tvlooy thanks for this nice little tip. I hope DoctrineBundle fixes it in the future and this is no longer needed. By the way, we merged this in 2.7 branch.

javiereguiluz added a commit that referenced this pull requestJan 29, 2018
This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes#9141).Discussion----------Update doctrine.rstmy doctrine.yml had a ```charset: utf8mb4``` but my schema update generated tables with utf8. Seems like there is a separate configuration directive for the tables and this is not inherited from the databaseCommits-------81f9051 Update doctrine.rst
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

4 participants

@tvlooy@xabbuh@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp