Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Recommend being lenient only with other vendors#9062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
If a bundle introduces a deprecation, it should not use the deprecated path itself anymore.
stof commentedJan 15, 2018
indeed, much better. This mode was not available yet when I wrote the config files which served as inspiration to this recommendation, but it is indeed a better idea. |
javiereguiluz commentedJan 15, 2018
@greg0ire thanks for this. Two quick questions:
Thanks! |
greg0ire commentedJan 15, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This is ready on Symfony side, you may be confused by the upcoming
It is available since v3.3.0-BETA1 (seesymfony/symfony#21539) |
stof commentedJan 15, 2018
and note that this is related to the PHPUnit bridge version, which is decoupled from the Symfony version being tested (i.e. bundle should always use |
javiereguiluz commentedJan 15, 2018
OK thanks. I'm still confused about which branch should I merge this in: 3.3 or 4.0? |
greg0ire commentedJan 15, 2018
It changes a recently added paragraph by@Nyholm and others. It was added on 4.0. Seehttps://twitter.com/dbu/status/952831321822388225 |
javiereguiluz commentedJan 15, 2018
Thank you Grégoire. |
This PR was merged into the 4.0 branch.Discussion----------Recommend being lenient only with other vendorsIf a bundle introduces a deprecation, it should not use the deprecated path itself anymore.Commits-------64a9aa5 Recommend being lenient only with other vendors
stof commentedJan 15, 2018
@javiereguiluz the feature used here exists since SF 3.3. But the article in best practices has this content only for new versions of the doc. This is what creates confusion in the discussion. |
If a bundle introduces a deprecation, it should not use the deprecated
path itself anymore.