Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[TwigBundle] Fix default value of strict_variables#9050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
javiereguiluz approved these changesJan 13, 2018
Member
javiereguiluz commentedJan 13, 2018
Thank you Yonel. |
javiereguiluz added a commit that referenced this pull requestJan 13, 2018
This PR was merged into the 2.7 branch.Discussion----------[TwigBundle] Fix default value of strict_variablesSeehttps://github.com/symfony/symfony/blob/d78a98d793c2846d6decbff652d63f981e4f32f4/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php#L177However, I'm proposing revert it since 4.1 and fix it inside the configuration section, see#9049Commits-------3888217 Fix default value of strict_variables
fabpot added a commit to symfony/symfony that referenced this pull requestFeb 6, 2018
…ebug" as default value of "strict_variable" (yceruto)This PR was merged into the 4.1-dev branch.Discussion----------[TwigBundle] Deprecating "false" in favor of "kernel.debug" as default value of "strict_variable"| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | ->http://symfony.com/doc/current/reference/configuration/twig.html#strict-variables>**strict_variables**> **type**: boolean **default**: `'%kernel.debug%'`Nope, really it's `false` by default:https://github.com/symfony/symfony/blob/1df45e43563a37633b50d4a36478090361a0b9de/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php#L130Fixing it insymfony/symfony-docs#9050, but yes `'%kernel.debug%'` is a better default value, the [TwigBundle recipe](https://github.com/symfony/recipes/blob/bf2148f9f1fe5af7e19c3145b6f7246c6cabb3a5/symfony/twig-bundle/3.3/config/packages/twig.yaml#L4:) affirms that:```yamltwig: # ... strict_variables: '%kernel.debug%'```So yeah, it definitely looks like it should be the default value, wdyt?Commits-------922878e Deprecating "false" as default value of "strict_variable" under Twig configuration
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seehttps://github.com/symfony/symfony/blob/d78a98d793c2846d6decbff652d63f981e4f32f4/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php#L177
However, I'm proposing revert it since 4.1 and fix it inside the configuration section, see#9049