Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Updated the translation/* articles to Symfony 4#8733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
yceruto commentedNov 23, 2017
Could you to update the framework reference to add the default path option?https://github.com/symfony/symfony-docs/pull/8634/files#diff-c0c158a40398b72fa4f0c9d0accbc169 |
javiereguiluz commentedNov 23, 2017
@yceruto sorry but I can't. I don't see the default_path in my branch or in 4.0. Is this only on master? |
yceruto commentedNov 23, 2017
@javiereguiluz are you asking by Symfony repo or docs? I don't understand the question :/ https://github.com/symfony/symfony-docs/pull/8634/files#diff-c0c158a40398b72fa4f0c9d0accbc169 It needs to be added to the framework reference? |
javiereguiluz commentedNov 23, 2017
yes, I was referring to the docs ... but I'm probably wrong. |
weaverryan commentedNov 24, 2017
@javiereguiluz He already did the work for you :).@yceruto just wants you to import his work from another PR:https://github.com/symfony/symfony-docs/pull/8634/files#diff-c0c158a40398b72fa4f0c9d0accbc169 |
weaverryan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor changes, then 👍 from me
translation.rst Outdated
| ------------ | ||
| In applications using:doc:`Symfony Flex</setup/flex>`, run this command to | ||
| install the translator before using it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not mentioning this in 4.0: I'm assuming they have Flex installed and have that dir structure. If we don't assume this, then the docs become a mess.
translation.rst Outdated
| Translations are handled by a ``translator`` service that usestheuser's | ||
| localeto lookupandreturn translated messages. Before using it, enable the | ||
| ``translator`` in your configuration: | ||
| The previous creates an initial config file where you can definethedefault |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The previous command...
translation.rst Outdated
| localeto lookupandreturn translated messages. Before using it, enable the | ||
| ``translator`` in your configuration: | ||
| The previous creates an initial config file where you can definethedefault | ||
| localeof the appandthe:ref:`fallback locales<translation-fallback>` used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
... fallback locales that will be used if Symfony...
weaverryan commentedNov 27, 2017
Status: Needs work |
No description provided.