Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Updated the best practice article about config#8722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
weaverryan commentedNov 21, 2017
@javiereguiluz other PR's are merged now! I've also changed your target branch to 4.0 - but that shouldn't affect you at all (I just don't want to forget to switch on merge) |
Member
weaverryan commentedNov 24, 2017
Thanks Javier! I only made one small change |
weaverryan added a commit that referenced this pull requestNov 24, 2017
…iluz, weaverryan)This PR was merged into the 4.0 branch.Discussion----------Updated the best practice article about configThis was the only remaining article to be updated in "Best Practices".Related to this:* The main config.rst is being updated in ~~#8588~~* Some config/* articles are being updated in ~~#8647~~.* I'm going to update the rest of config/* articles.Commits-------175a4e8 minor tweaksb973f0c Updated the best practice article about config
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This was the only remaining article to be updated in "Best Practices".
Related to this:
Updated main configuration guide to Flex #8588Made two more configuration guides flex-ready #8647.