Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Update HttpCache kernel documentation for Symfony 4#8696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Update HttpCache kernel documentation for Symfony 4#8696
Conversation
javiereguiluz commentedNov 18, 2017
I guess this is duplicated of#8682 ... these days we're updating all docs, so please check the open PR and create an issue saying that you are going to work on some files. Thanks! |
michaelperrin commentedNov 18, 2017
Thanks@javiereguiluz . That's too bad because I checked but didn't see your PR, my bad. The cool thing is that@weaverryan proposes the same name for the caching kernel, so it seems its quite a natural one :) You can close this PR then if you wish! |
weaverryan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@michaelperrin if you are able to make the suggested changes faster than Javier, then I would be happy to merge your's in. Javier's PR has additional changes - so he could just rebase after your merge. But, quick! Symfony 4 is upon us! :)
http_cache.rst Outdated
| To enable caching, modify the code of your front controller. You can also make these | ||
| changes to ``index.php`` to add caching to the ``dev`` environment:: | ||
| // src/CacheKernel.php | ||
| <?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
remove the<?php
| Modify the code of your front controller to wrap the default kernel into the | ||
| caching kernel:: | ||
| // public/index.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's change the:: to just: and add (on the next line).. code-block:: diff.
Then, you can add + and - to emphasize the changes:
.. code-block:: diff // some line from before - // line to go away + // line to addThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's great advice, thanks :) I could check that everything is fine by compiling the doc with Sphinx.
865d565 tob15dba2Comparemichaelperrin commentedNov 22, 2017
@weaverryan I made the changes you requested :) |
weaverryan commentedNov 27, 2017
Thank you Michaël! |
…chaelperrin)This PR was merged into the 4.0 branch.Discussion----------Update HttpCache kernel documentation for Symfony 4#SymfonyConHackday2017I am not entirely sure that we should document this way (creating a `src/CacheKernel.php` file as I propose here). Feel free to comment :)Commits-------b15dba2 Update HttpCache kernel documentation for Symfony 4
#SymfonyConHackday2017
I am not entirely sure that we should document this way (creating a
src/CacheKernel.phpfile as I propose here). Feel free to comment :)