symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

Document allow outdated vendors mode#8686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

greg0ire wants to merge2 commits intosymfony:masterfromgreg0ire:weak_lagging_vendors

Closed

Document allow outdated vendors mode#8686

greg0ire wants to merge2 commits intosymfony:masterfromgreg0ire:weak_lagging_vendors

Conversation

Copy link

Contributor

greg0ire commentedNov 16, 2017

Refssymfony/symfony#24867

carsonbot added the Status: Needs Review label

Nov 16, 2017

greg0ire mentioned this pull request

Nov 16, 2017

[PhpUnitBridge]allow outdated vendors modesymfony/symfony#24867

Closed

xabbuh added the On hold label

Nov 16, 2017

OskarStark approved these changes

Nov 17, 2017

View reviewed changes

weaverryan added the Waiting Code MergeDocs for features pending to be merged label

Nov 21, 2017

Copy link

ContributorAuthor

greg0ire commentedDec 1, 2017

I wonder if should add a table to recommend a usage:

strict: recommended for actively maintained projects with few dependencies
<some_integer> recommended to transition towards strictness
weak_lagging_vendors: recommended in projects when strict cannot be attained
weak_vendors: recommended in libraries that struggle to keep up with deprecations
weak: not recommended

javiereguiluz removed the On hold label

Jan 25, 2018

rzilin approved these changes

Jan 29, 2018

View reviewed changes

greg0ire force-pushed theweak_lagging_vendors branch from6301a75 to9e6d8b0Compare

January 29, 2018 18:42

greg0ire changed the title~~Document weak lagging vendors mode~~Document allow outdated vendors mode

Jan 29, 2018

Copy link

ContributorAuthor

greg0ire commentedJan 29, 2018

Here is how the table looks:

OskarStark reviewed

Jan 30, 2018

View reviewed changes

components/phpunit_bridge.rst Outdated

		own dependencies, meaning they do not fix deprecations as soon as
		possible, which means there is nothing you can do to fix that (apart
		from a pull request on the outdated vendor). This mode allows you to
		ignore those deprecations, allowing you to notice when your code is

Copy link

Contributor

OskarStarkJan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

maybe displayyour code bold?

Copy link

ContributorAuthor

greg0ireJan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Or even better,italics.

OskarStark reviewed

Jan 30, 2018

View reviewed changes

components/phpunit_bridge.rst


		+------------------------+-----------------------------------------------------+
		\| Mode\| Recommended situation\|
		+========================+=====================================================+

Copy link

Contributor

OskarStarkJan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Recommended repeats a lot

Copy link

ContributorAuthor

greg0ireJan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, not sure what to do about that…

greg0ire added2 commits

January 30, 2018 08:43

Document allow outdated vendors mode

ed845bd

Refssymfony/symfony#24867

Add a table to summarize the modes

e7dee0c

greg0ire force-pushed theweak_lagging_vendors branch fromeea6f57 toe7dee0cCompare

January 30, 2018 07:44

Copy link

Member

javiereguiluz commentedFeb 9, 2018

@greg0ire the related PR (symfony/symfony#24867) was closed. Could you please tell us if this PR is still relevant or another one is needed to document the changes mentioned in the closed PR? Thanks!