Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Updated http_cache/* articles to Symfony 4#8682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 3 commits intosymfony:4.0fromjaviereguiluz:update_http_cache
Nov 27, 2017

Conversation

@javiereguiluz
Copy link
Member

I have a question about the oldAppCache class. I've moved tosrc/AppCache.php underApp namespace. Is that correct? And also: should we rename it toCache orKernelCache or something else? AppCache was great when we had AppKernel ... but now we have just Kernel.

@weaverryan
Copy link
Member

Hmmmm.

Two things:

  1. One big difference is that, in Flex, you will need tocreate the "cache" kernel file, because you do not have it by default (like in the SE).@javiereguiluz have you made changes to the docs to reflect this? I admittedly only did a quick scan, but I didn't see it. It's out-of-scope, but perhaps we need amake: command to create this for you (and at leastsuggest the changes you also need inindex.php).

  2. What to call this class? I thinkCacheKernel - it's your kernel, but aCache version if it :).

@weaverryan
Copy link
Member

Status: Needs work

@weaverryan
Copy link
Member

Thanks!

@weaverryanweaverryan merged commit1e75772 intosymfony:4.0Nov 27, 2017
weaverryan added a commit that referenced this pull requestNov 27, 2017
…, weaverryan)This PR was merged into the 4.0 branch.Discussion----------Updated http_cache/* articles to Symfony 4I have a question about the old `AppCache` class. I've moved to `src/AppCache.php` under `App` namespace. Is that correct? And also: should we rename it to `Cache` or `KernelCache` or something else? AppCache was great when we had AppKernel ... but now we have just Kernel.Commits-------1e75772 Merge branch '4.0' into update_http_cache664f280 Merge branch '4.0' into update_http_cached512875 Updated http_cache/* articles to Symfony 4
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javiereguiluz@weaverryan@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp